Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI overlap issue on student report page for mobile screen. #1426

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

vinutv
Copy link
Contributor

@vinutv vinutv commented Aug 31, 2023

@pupilfirst/developers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
    • Add tests for authorization, if required.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
    • Users::DeleteAccountService
    • Courses::CloneService
    • Courses::DeleteService
    • Courses::DemoContentService
    • Levels::CloneService
    • Schools::DeleteService
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c14300b
Status: ✅  Deploy successful!
Preview URL: https://8a5c0ccc.pupilfirst-docs.pages.dev
Branch Preview URL: https://issues-1425-mobile-report-ui.pupilfirst-docs.pages.dev

View logs

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish merged commit 0362a0d into master Aug 31, 2023
4 checks passed
yash-learner pushed a commit to yash-learner/pupilfirst that referenced this pull request Aug 31, 2023
@harigopal harigopal deleted the issues/1425/mobile-report-ui-overlap branch September 13, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete display of notes and submissions list due to overlapping bottom navigation on mobile screens.
2 participants