Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/126/add access ends picker #143

Merged
merged 33 commits into from Dec 13, 2019
Merged

Issues/126/add access ends picker #143

merged 33 commits into from Dec 13, 2019

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Dec 6, 2019 •
edited

Fix #126

  • Add spec

@bodhish
Convert school courses students pack to Jsx3
0fae9ca
@bodhish
Use replace custom blanket classes with SchoolAdmin__EditorDrawer
54d614b
@bodhish
Add a seperate tab for actions in course students edit
f09511d
@bodhish
Wire access ends on for foudners in UI
75e18e1
@bodhish
Update actions in active students panel
a74e092
@bodhish
Update active student panel design
076033b
@bodhish
Add dropout student mutation
e8b65e3
@bodhish
Clean up mark as exited service
ad93a7c
@bodhish
Add exited_on to founders
1f36fb2
@bodhish
Replace uages of founders exited flag with exited_on
4164232
@bodhish
Remove uages of founders exited flag
f75b101
@bodhish
Remove exited flag
9117d32
@bodhish
Update founders edit form
2df23b4
@bodhish
Wire dropout student mutation
f0faa3a
@bodhish
Set access ends at for startup in mark as exited service
4bb71ee
@bodhish
Rename exited_on to exited_at in founders table
37e56c7
@bodhish
Replace usages of exited_at with exited_on
bd5c99f
@bodhish
Move exited_at from student to team
af67180
@bodhish
Replace all usages of exited_at
d762222
@bodhish
Remove exited prop from school students index
fa0ba4d
@bodhish
Add exited startups to inactive scope
948633c
@bodhish
Add fa-spinner to dropout button
59ef956
bodhish
bodhish commented Dec 9, 2019
View reviewed changes
db/schema.rb Outdated Show resolved Hide resolved
mahesh-krishnakumar
mahesh-krishnakumar suggested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mahesh-krishnakumar mahesh-krishnakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodhish Check the comments

@bodhish
Copy link
Member Author

bodhish commented Dec 10, 2019

@mahesh-krishnakumar re-review 😄

bodhish and others added 4 commits December 10, 2019 16:17
@bodhish
Merge branch 'master' into issues/126/add-access-ends-picker
2ddad66
@harigopal
Add documentation for the newly added team access end date field
b85aefa 
This also restores the _Inactive Students_ name for the button at the
top right of the list in order to make it easy to distinguish between
'active' and 'inactive' students.
@harigopal
Minor update to Inactive Students documentation
960b590
@harigopal
Use updated labels in admin students index spec
dfaaaa5
@bodhish bodhish merged commit eb14647 into master Dec 13, 2019
@bodhish bodhish deleted the issues/126/add-access-ends-picker branch December 23, 2019 17:59
@harigopal harigopal mentioned this pull request Jan 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-krishnakumar mahesh-krishnakumar mahesh-krishnakumar requested changes

@harigopal harigopal harigopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow school admins to set the date on which the course access for a student ends
3 participants
@bodhish @harigopal @mahesh-krishnakumar