Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unique indices for course exports cohort and quiz #1462

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Add unique indices for course exports cohort and quiz #1462

merged 9 commits into from
Oct 20, 2023

Conversation

chahmedejaz
Copy link
Contributor

@chahmedejaz chahmedejaz commented Oct 13, 2023 •
edited

Proposed Changes

This PR adds following changes:

  • Unique index on the CourseExportsCohort' course_export_id and cohort_id columns
  • Unique index on the Quizzes' target_id column

@pupilfirst/developers

Resolves: #1431, #1456

@mahesh-krishnakumar mahesh-krishnakumar changed the title Task/1431 uniq indices for course exports cohort and quiz Add unique indices for course exports cohort and quiz Oct 16, 2023
@mahesh-krishnakumar mahesh-krishnakumar linked an issue Oct 16, 2023 that may be closed by this pull request
Add foreign keys and composite indexes in course_exports_cohorts table #1456
Closed
@chahmedejaz
Copy link
Contributor Author

chahmedejaz commented Oct 17, 2023 •
edited

Hey @mahesh-krishnakumar - I've addressed your comments. Can you please review? Thanks.

@mahesh-krishnakumar mahesh-krishnakumar merged commit 68c88f5 into pupilfirst:master Oct 20, 2023
2 of 3 checks passed
@mahesh-krishnakumar
Copy link
Contributor

Thank you for the PR @chahmedejaz 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-krishnakumar mahesh-krishnakumar mahesh-krishnakumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chahmedejaz @mahesh-krishnakumar