New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul target editor #176
Commits on Jan 13, 2020
Commits on Jan 14, 2020
-
-
-
-
-
Create graph query to fetch target details
Mahesh Krishna Kumar committedJan 14, 2020 -
Create target details component and load target data
Mahesh Krishna Kumar committedJan 14, 2020
Commits on Jan 15, 2020
Commits on Jan 16, 2020
-
Add quiz data to target details query
Mahesh Krishna Kumar committedJan 16, 2020 -
Revert changes to old types for quiz
Mahesh Krishna Kumar committedJan 16, 2020 -
Add title and prerequisites to target details editor
Mahesh Krishna Kumar committedJan 16, 2020 -
Merge branch 'master' into overhaul-target-editor
Mahesh Krishna Kumar committedJan 16, 2020 -
Fix issue with setting state for prerequisite target ids
Mahesh Krishna Kumar committedJan 16, 2020 -
Implement evaluation criteria selector in target editor
Mahesh Krishna Kumar committedJan 16, 2020 -
WIP: Add link to complete field for target editor
Mahesh Krishna Kumar committedJan 16, 2020
Commits on Jan 17, 2020
-
TargetDrawer: Fix crash on opening editor for new target
Mahesh Krishna Kumar committedJan 17, 2020 -
Add method of completion selector in target details editor
Mahesh Krishna Kumar committedJan 17, 2020 -
-
Add quiz to target details editor
Mahesh Krishna Kumar committedJan 17, 2020 -
Avoid N+1 queries in target details resolver
Mahesh Krishna Kumar committedJan 17, 2020 -
Commits on Jan 20, 2020
-
-
Merge branch 'master' into overhaul-target-editor
Mahesh Krishna Kumar committedJan 20, 2020
Commits on Jan 21, 2020
-
Add visibility field to target editor
Mahesh Krishna Kumar committedJan 21, 2020 -
WIP: Create mutation to update targets [skip ci]
Mahesh Krishna Kumar committedJan 21, 2020 -
Fix issue with quiz input type in mutation
Mahesh Krishna Kumar committedJan 21, 2020
Commits on Jan 22, 2020
-
Create mutation to update target details
Mahesh Krishna Kumar committedJan 22, 2020 -
Refactor types and elements in target details editor
Mahesh Krishna Kumar committedJan 22, 2020 -
Add disabling cover to target details editor
Mahesh Krishna Kumar committedJan 22, 2020 -
Fix crash while updating target quiz
Mahesh Krishna Kumar committedJan 22, 2020 -
Add a concern to authorize course authors
Mahesh Krishna Kumar committedJan 22, 2020 -
Update target visibility in component state
Mahesh Krishna Kumar committedJan 22, 2020
Commits on Jan 23, 2020
-
Merge branch 'master' into overhaul-target-editor
Mahesh Krishna Kumar committedJan 23, 2020 -
-
-
-
Improve label styling for target editor form
Mahesh Krishna Kumar committedJan 23, 2020 -
-
-
-
-
Fix margin for target editor input fields
Mahesh Krishna Kumar committedJan 23, 2020
Commits on Jan 24, 2020
-
-
Simplify target type for curriculum index
Mahesh Krishna Kumar committedJan 24, 2020 -
Avoid preloading data for targets in curriculum index
Mahesh Krishna Kumar committedJan 24, 2020 -
Scope targets by school in update target mutator
Mahesh Krishna Kumar committedJan 24, 2020 -
-
Update target basic info updates to parent component
Mahesh Krishna Kumar committedJan 24, 2020
Commits on Jan 25, 2020
Commits on Jan 27, 2020
-
Rename components for handling quiz in target editor
Mahesh Krishna Kumar committedJan 27, 2020 -
Commits on Jan 28, 2020
-
-
-
-
-
-
-
-
WIP: Create a generic multiselect inline component [skip ci]
Mahesh Krishna Kumar committedJan 28, 2020
Commits on Jan 29, 2020
-
-
Improve styling of selected items in dropdown
Mahesh Krishna Kumar committedJan 29, 2020 -
Improve texts in the multiselect inline component
Mahesh Krishna Kumar committedJan 29, 2020 -
-
-
-
Use multiselect dropdown for setting evaluation criteria
Mahesh Krishna Kumar committedJan 29, 2020 -
Commits on Jan 30, 2020
-
Allow multiselect inline component to accept color for selected
Mahesh Krishna Kumar committedJan 30, 2020 -
Improve select icon for multiselect dropdown list
Mahesh Krishna Kumar committedJan 30, 2020 -
-
-
Set dirty in editor drawer when target details are changed
Mahesh Krishna Kumar committedJan 30, 2020
Commits on Jan 31, 2020
Commits on Feb 2, 2020
-
-
-
Add a new multiselect-inline package
Mahesh Krishna Kumar committedFeb 2, 2020 -
Merge branch 'master' into overhaul-target-editor
Mahesh Krishna Kumar committedFeb 2, 2020 -
Use multiselect inline component from packages
Mahesh Krishna Kumar committedFeb 2, 2020 -
Update correct state while selecting evaluation criterion
Mahesh Krishna Kumar committedFeb 2, 2020
Commits on Feb 3, 2020
-
-
-
Add spec for target details editor
Mahesh Krishna Kumar committedFeb 3, 2020 -
-
Create target version on creating a new target
Mahesh Krishna Kumar committedFeb 3, 2020 -
Cleanup and simplify curriculum editor spec
Detailed checks on modifying target properties and content is now covered in target_details_editor_spec and target_content_editor_spec respectively.
Mahesh Krishna Kumar committedFeb 3, 2020 -
-
Merge branch 'overhaul-target-editor' of https://github.com/SVdotCO/p…
…upilfirst into overhaul-target-editor
-
-
-
-
Handle target versions in course clone service
Mahesh Krishna Kumar committedFeb 3, 2020 -
Create factory for target versions
Mahesh Krishna Kumar committedFeb 3, 2020 -
-
Mahesh Krishna Kumar committed
Feb 3, 2020
Commits on Feb 4, 2020
-
-
-
-
-
Create an example page for multiselect inline package
Mahesh Krishna Kumar committedFeb 4, 2020 -
Mahesh Krishna Kumar committed
Feb 4, 2020 -
Reset search text in on selecting an item
Mahesh Krishna Kumar committedFeb 4, 2020 -
-
Merge branch 'overhaul-target-editor' of github.com:SVdotCO/pupilfirs…
…t into overhaul-target-editor
-
Commits on Feb 5, 2020
-
Cleanup components for the old target editor
Mahesh Krishna Kumar committedFeb 5, 2020 -
-
Mahesh Krishna Kumar committed
Feb 5, 2020 -
-
-
Cleanup unused target update route
Mahesh Krishna Kumar committedFeb 5, 2020 -
-
Update documentation for multiselect inline pack
Mahesh Krishna Kumar committedFeb 5, 2020 -
- @pupilfirst/multiselect-dropdown@0.1.8 - @pupilfirst/multiselect-inline@1.0.1 - @pupilfirst/pf-icon@0.1.10
Mahesh Krishna Kumar committedFeb 5, 2020
Commits on Feb 6, 2020
-
-
-
-
-
-
-
-
Seed content blocks properly with a target version
... and use TargetContentView component to render embed block in the target content editor.
-
Only report dirty content block status when absolutely required
This improves performance of typing / editing anything about content blocks in the new content editor massively. The earlier implementation reported dirty status to the parent component for every single change regardless of whether the dirty state had changed. This is fixed by keeping a local state of the dirty status and reporting to parent only if the the new state doesn't match the local state. This commit also fixes a bad commenting-out of the previewing functionality of the new markdown editor.
Commits on Feb 7, 2020
-
-
Make quick links on curriculum editor target rows larger
This change also gets rid of the messy hyperlink nesting in each listed target, opting to put the hyperlinks side-by-side instead.
-
Upgrade all JSX3 usage of v1 Markdown editor to v2
This also runs the spec for v1 Markdown editor against v2 (there aren't any real changes there), and updates the v2 editor to not render the previewing `MarkdownBlock` in hidden state, opting to render it only when it's required on-screen.
-
Use padding instead of margin for vertical spacing in most markdown-r…
…endered elements
Commits on Feb 8, 2020
-
-
Remove trailing semicolon from v2 Markdown editor's CSS
This fixes broken styling in an unrelated component, caused by the presence of the syntax-breaking semicolon in a compiled CSS file. This commit also configures the stylelint package to catch such errors (and many others) in its new rc file.
-
Commits on Feb 10, 2020
-
Refactor class names for multiselect-inline component
Mahesh Krishna Kumar committedFeb 10, 2020 -
-
-
-
-
-
-
MultiselectInline: Add a message when all items are selected
Mahesh Krishna Kumar committedFeb 10, 2020 -
Add custom message to multiselect inline documentation
Mahesh Krishna Kumar committedFeb 10, 2020 -
-
Minor update to multiselect-inline package documentation
Mahesh Krishna Kumar committedFeb 10, 2020 -
-
Add few validations in update target mutator
Mahesh Krishna Kumar committedFeb 10, 2020 -
Cleanup unused update target form and service
Mahesh Krishna Kumar committedFeb 10, 2020 -
Refactor couple of function names in TargetDetails type
Mahesh Krishna Kumar committedFeb 10, 2020 -
Bring back the target update service
Mahesh Krishna Kumar committedFeb 10, 2020
Commits on Feb 11, 2020
-
Refactor css classnames for inline dropdown component
Mahesh Krishna Kumar committedFeb 11, 2020 -
Add url validation for target#link_to_complete
Mahesh Krishna Kumar committedFeb 11, 2020 -
UpdateTargetMutator: Link to complete could be blank
Mahesh Krishna Kumar committedFeb 11, 2020 -
-
-
TargetShowSpec: All targets should have content
Mahesh Krishna Kumar committedFeb 11, 2020 -