New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a target completion/evaluation checklist for students and coaches #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CO/pupilfirst into issues/29/target-checklist
harigopal
requested changes
Feb 27, 2020
app/javascript/courses/curricula/components/CoursesCurriculum__SubmissionBuilder.re
Outdated
Show resolved
Hide resolved
app/javascript/courses/curricula/components/CoursesCurriculum__SubmissionBuilder.re
Outdated
Show resolved
Hide resolved
app/javascript/courses/curricula/components/CoursesCurriculum__SubmissionItem.re
Outdated
Show resolved
Hide resolved
app/javascript/courses/curricula/components/CoursesCurriculum__SubmissionItem.re
Outdated
Show resolved
Hide resolved
app/javascript/courses/curricula/components/CoursesCurriculum__SubmissionBuilder.re
Outdated
Show resolved
Hide resolved
…CO/pupilfirst into issues/29/target-checklist
…CO/pupilfirst into issues/29/target-checklist
…CO/pupilfirst into issues/29/target-checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
After merge
description
andlinks
from timeline eventA target that is reviewed by a coach will now have a checklist, which is a series of steps that a student needs to do as part of completing the target and submitting it. Each step can have an action (like short text, long text, file attachment, etc. ) or no action. Each step in the checklist can be optional as well. The target checklist will be stored as a
jsonb
field (Target#checklist
) with the following shape:The student performs each of these steps using the submission interface and on submission, the response will be stored in a
jsonb
fieldTimelineEvent#checklist
. An example checklist response :The valid types for kind:
["files", "link", "long_text", "multi_choice", "short_text"]
The coach in his/her review interface will verify a submission against each of these steps in the checklist. Based on the response from the coach the
review
field for each checklist item will be updated tonil/true/false