Create --offline flag to disable git functionality #53
Conversation
|
@pabelanger would you mind fixing the broken tests? |
|
There will often be cases when you do want to clone the repos, you just don't want to push. Could we instead add a different flag to handle this? |
|
@cmurphy suggestions on flag name? --disable-git? --without-git? |
|
--no-pull? --no-clone? --without-clone? Maybe a --offline that neither pulls nor pushes? |
|
--offline works. Let me refactor |
cmurphy
changed the title
|
Also @danzilio might want to take a look since he's working on a refactor |
| @@ -56,8 +56,10 @@ def self.run(args) | |||
| # managed_modules is either an array or a hash | |||
| managed_modules.each do |puppet_module, opts| | |||
| puts "Syncing #{puppet_module}" | |||
| git_base = "#{options[:git_base]}#{options[:namespace]}" | |||
| Git.pull(git_base, puppet_module, options[:branch], opts || {}) | |||
| if not options[:offline] | |||
There was a problem hiding this comment.
a more idiomatic way to put this would be unless options[:offline]
|
The |
|
Could some instructions for the new flag be added to https://github.com/puppet-community/modulesync#dry-run please? |
| @@ -78,6 +80,7 @@ def self.run(args) | |||
| end | |||
| end | |||
| files_to_manage -= files_to_delete | |||
| next if options[:offline] | |||
There was a problem hiding this comment.
I think we do still want the update_noop to happen in offline mode (it just prints the diffs to stdout)
This allows existing cloned projects to be used for testing purposes. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
| @@ -80,7 +82,7 @@ def self.run(args) | |||
| files_to_manage -= files_to_delete | |||
| if options[:noop] | |||
| Git.update_noop(puppet_module, options) | |||
| else | |||
| elsif not options[:offline] | |||
There was a problem hiding this comment.
I don't think this addresses #53 (comment)
I think line 83 should be if options[:noop] || options[:offline] since we want the same behavior (printing out the changes without making updates)
There was a problem hiding this comment.
So, if we do that, we're changing the way --noop actually works. Since now, we get output with both --noop or --offline.
This way, you have to pass both --offline --noop if you want to see the diff. Other wise, --offline does nothing related to git.
Create --offline flag to disable git functionality
This adds the offline parameter from voxpupuli#53. This also adds some more documentation to README.md.
This is our hook from the propose_update.sh script. It is also dependant on the following features upstream: voxpupuli/modulesync#53 voxpupuli/modulesync#54 Change-Id: I8b9e7edd564e55eaba8ed95294bd185f0fe2a585 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This allows existing cloned projects to be used for testing purposes.
Signed-off-by: Paul Belanger pabelanger@redhat.com