Skip to content

Commit

Permalink
fix(NetworkManager): Remove header 'cookie' from request hash (#2954)
Browse files Browse the repository at this point in the history
This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

References #2970
  • Loading branch information
DonoA authored and aslushnikov committed Jul 31, 2018
1 parent 392d3b9 commit 0b12119
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/NetworkManager.js
Expand Up @@ -675,7 +675,7 @@ function generateRequestHash(request) {
for (let header of headers) {
const headerValue = request.headers[header];
header = header.toLowerCase();
if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id')
if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id' || header === 'cookie')
continue;
hash.headers[header] = headerValue;
}
Expand Down

0 comments on commit 0b12119

Please sign in to comment.