Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r656675 (#4389)
Browse files Browse the repository at this point in the history
This roll includes:
- https://chromium-review.googlesource.com/c/v8/v8/+/1569425 - [debug] Introduce GetCreationContext to debug API

Fix #4263
  • Loading branch information
aslushnikov committed May 6, 2019
1 parent 1de9906 commit 13f73b5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -8,7 +8,7 @@
"node": ">=6.4.0"
},
"puppeteer": {
"chromium_revision": "654752"
"chromium_revision": "656675"
},
"scripts": {
"unit": "node test/test.js",
Expand Down
2 changes: 1 addition & 1 deletion test/page.spec.js
Expand Up @@ -286,7 +286,7 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
const values = await page.evaluate(objects => Array.from(objects[0].values()), objectsHandle);
expect(values).toEqual(['hello', 'world']);
});
xit('should work for non-blank page', async({page, server}) => {
it('should work for non-blank page', async({page, server}) => {
// Instantiate an object
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => window.set = new Set(['hello', 'world']));
Expand Down

0 comments on commit 13f73b5

Please sign in to comment.