chore: fix lint errors.

puppeteer · Oct 13, 2021 · 16ba01e · 16ba01e
1 parent df5a414
commit 16ba01e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/node/Launcher.ts b/src/node/Launcher.ts
@@ -416,9 +416,9 @@ class FirefoxLauncher implements ProductLauncher {
     return firefoxArguments;
   }
 
-  defaultPreferences(extraPrefs: {
+  defaultPreferences(extraPrefs: { [x: string]: unknown }): {
     [x: string]: unknown;
-  }): { [x: string]: unknown } {
+  } {
     const server = 'dummy.test';
 
     const defaultPrefs = {

diff --git a/test/launcher.spec.ts b/test/launcher.spec.ts
@@ -312,7 +312,11 @@ describe('Launcher specs', function () {
         } else if (isFirefox) {
           expect(puppeteer.defaultArgs()).toContain('--headless');
           expect(puppeteer.defaultArgs()).toContain('--no-remote');
-          expect(puppeteer.defaultArgs()).toContain('--foreground');
+          if (os.platform() === 'darwin') {
+            expect(puppeteer.defaultArgs()).toContain('--foreground');
+          } else {
+            expect(puppeteer.defaultArgs()).not.toContain('--foreground');
+          }
           expect(puppeteer.defaultArgs({ headless: false })).not.toContain(
             '--headless'
           );
@@ -514,8 +518,10 @@ describe('Launcher specs', function () {
         async () => {
           const { puppeteer } = getTestState();
           const consoleStub = sinon.stub(console, 'warn');
-          // @ts-expect-error purposeful bad input
-          const browser = await puppeteer.launch({ product: 'SO_NOT_A_PRODUCT'});
+          const browser = await puppeteer.launch({
+            // @ts-expect-error purposeful bad input
+            product: 'SO_NOT_A_PRODUCT',
+          });
           const userAgent = await browser.userAgent();
           await browser.close();
           expect(userAgent).toContain('Chrome');