fix: test expectations

puppeteer · Sep 13, 2023 · 1ed5746 · 1ed5746
1 parent 2bff2e7
commit 1ed5746
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/packages/puppeteer-core/src/common/Accessibility.ts b/packages/puppeteer-core/src/common/Accessibility.ts
@@ -354,6 +354,7 @@ class AXNode {
       case 'doc-cover':
       case 'graphics-symbol':
       case 'img':
+      case 'image':
       case 'Meter':
       case 'scrollbar':
       case 'slider':

diff --git a/packages/puppeteer-core/src/common/AriaQueryHandler.ts b/packages/puppeteer-core/src/common/AriaQueryHandler.ts
@@ -64,7 +64,7 @@ const normalizeValue = (value: string): string => {
  * The following examples showcase how the syntax works wrt. querying:
  *
  * - 'title[role="heading"]' queries for elements with name 'title' and role 'heading'.
- * - '[role="img"]' queries for elements with role 'img' and any name.
+ * - '[role="image"]' queries for elements with role 'image' and any name.
  * - 'label' queries for elements with name 'label' and any role.
  * - '[name=""][role="button"]' queries for elements with no name and role 'button'.
  */

diff --git a/test/src/accessibility.spec.ts b/test/src/accessibility.spec.ts
@@ -338,7 +338,7 @@ describe('Accessibility', function () {
                 name: 'Edit this image: ',
               },
               {
-                role: 'img',
+                role: 'image',
                 name: 'my fake image',
               },
             ],

diff --git a/test/src/ariaqueryhandler.spec.ts b/test/src/ariaqueryhandler.spec.ts
@@ -390,7 +390,7 @@ describe('AriaQueryHandler', () => {
 
       let imgFound = false;
       const waitForSelector = page
-        .waitForSelector('aria/[role="img"]')
+        .waitForSelector('aria/[role="image"]')
         .then(() => {
           return (imgFound = true);
         });