feat!: drop support for node16

puppeteer · Sep 14, 2023 · 206ed08 · 206ed08
1 parent e8640ff
commit 206ed08
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 138 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -316,7 +316,7 @@ jobs:
           - macos-latest
           - windows-latest
         node:
-          - 18
+          - lts/*
         pkg_manager:
           - npm
     steps:

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/browsers/package.json b/packages/browsers/package.json
@@ -89,7 +89,7 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=16.3.0"
+    "node": ">=18.17.1"
   },
   "files": [
     "lib",

diff --git a/packages/ng-schematics/package.json b/packages/ng-schematics/package.json
@@ -45,15 +45,15 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=16.3.0"
+    "node": ">=18.17.1"
   },
   "dependencies": {
     "@angular-devkit/architect": "^0.1602.0",
     "@angular-devkit/core": "^16.2.0",
     "@angular-devkit/schematics": "^16.2.0"
   },
   "devDependencies": {
-    "@types/node": "^16.11.7",
+    "@types/node": "^18.17.15",
     "@schematics/angular": "^16.2.0",
     "@angular/cli": "^16.2.0",
     "rxjs": "7.8.1"

diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -31,7 +31,7 @@
     "url": "https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer-core"
   },
   "engines": {
-    "node": ">=16.3.0"
+    "node": ">=18.17.1"
   },
   "scripts": {
     "build:docs": "wireit",
@@ -142,7 +142,6 @@
   "dependencies": {
     "@puppeteer/browsers": "1.7.1",
     "chromium-bidi": "0.4.27",
-    "cross-fetch": "4.0.0",
     "debug": "4.3.4",
     "devtools-protocol": "0.0.1179426",
     "ws": "8.14.1"

diff --git a/packages/puppeteer-core/src/common/BrowserConnector.ts b/packages/puppeteer-core/src/common/BrowserConnector.ts
@@ -22,7 +22,6 @@ import {isErrorLike} from '../util/ErrorLike.js';
 import {CdpBrowser} from './Browser.js';
 import {Connection} from './Connection.js';
 import {ConnectionTransport} from './ConnectionTransport.js';
-import {getFetch} from './fetch.js';
 import type {ConnectOptions} from './Puppeteer.js';
 import {Viewport} from './PuppeteerViewport.js';
 import {debugError} from './util.js';
@@ -155,9 +154,8 @@ export async function _connectToCdpBrowser(
 async function getWSEndpoint(browserURL: string): Promise<string> {
   const endpointURL = new URL('/json/version', browserURL);
 
-  const fetch = await getFetch();
   try {
-    const result = await fetch(endpointURL.toString(), {
+    const result = await globalThis.fetch(endpointURL.toString(), {
       method: 'GET',
     });
     if (!result.ok) {

diff --git a/packages/puppeteer-core/src/common/common.ts b/packages/puppeteer-core/src/common/common.ts
@@ -69,6 +69,5 @@ export * from './Tracing.js';
 export * from './USKeyboardLayout.js';
 export * from './WaitTask.js';
 export * from './WebWorker.js';
-export * from './fetch.js';
 export * from './types.js';
 export * from './util.js';
diff --git a/packages/puppeteer-core/src/common/fetch.ts b/packages/puppeteer-core/src/common/fetch.ts
diff --git a/packages/puppeteer/package.json b/packages/puppeteer/package.json
@@ -31,7 +31,7 @@
     "url": "https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer"
   },
   "engines": {
-    "node": ">=16.3.0"
+    "node": ">=18.17.1"
   },
   "scripts": {
     "build:docs": "wireit",