Skip to content

Commit

Permalink
feat: roll to Chrome 117.0.5938.62 (r1181205) (#10893)
Browse files Browse the repository at this point in the history
Co-authored-by: Nikolay Vitkov <nvitkov@chromium.org>
  • Loading branch information
browser-automation-bot and Lightning00Blade committed Sep 13, 2023
1 parent 9b6f1de commit 4b8d20d
Show file tree
Hide file tree
Showing 11 changed files with 27 additions and 20 deletions.
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
Expand Up @@ -27,6 +27,7 @@
"test-types": "tsd -t packages/puppeteer",
"test:chrome:headful": "wireit",
"test:chrome:new-headless": "wireit",
"test:chrome:new-headless-tab": "wireit",
"test:chrome:headless": "wireit",
"test:chrome:bidi": "wireit",
"test:chrome:bidi-local": "wireit",
Expand Down Expand Up @@ -67,6 +68,9 @@
"test:chrome:new-headless": {
"command": "npm test -- --test-suite chrome-new-headless"
},
"test:chrome:new-headless-tab": {
"command": "npm test -- --test-suite chrome-new-headless-tab"
},
"test:chrome:bidi": {
"command": "npm test -- --test-suite chrome-bidi"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/puppeteer-core/package.json
Expand Up @@ -144,7 +144,7 @@
"chromium-bidi": "0.4.27",
"cross-fetch": "4.0.0",
"debug": "4.3.4",
"devtools-protocol": "0.0.1159816",
"devtools-protocol": "0.0.1179426",
"ws": "8.14.1"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/puppeteer-core/src/common/Accessibility.ts
Expand Up @@ -353,6 +353,7 @@ class AXNode {
case 'doc-cover':
case 'graphics-symbol':
case 'img':
case 'image':
case 'Meter':
case 'scrollbar':
case 'slider':
Expand Down
2 changes: 1 addition & 1 deletion packages/puppeteer-core/src/common/AriaQueryHandler.ts
Expand Up @@ -64,7 +64,7 @@ const normalizeValue = (value: string): string => {
* The following examples showcase how the syntax works wrt. querying:
*
* - 'title[role="heading"]' queries for elements with name 'title' and role 'heading'.
* - '[role="img"]' queries for elements with role 'img' and any name.
* - '[role="image"]' queries for elements with role 'image' and any name.
* - 'label' queries for elements with name 'label' and any role.
* - '[name=""][role="button"]' queries for elements with no name and role 'button'.
*/
Expand Down
5 changes: 0 additions & 5 deletions packages/puppeteer-core/src/common/NetworkManager.test.ts
Expand Up @@ -675,7 +675,6 @@ describe('NetworkManager', () => {
requestId: '1360.2',
timestamp: 10959.060708,
encodedDataLength: 85928,
shouldReportCorbBlocking: false,
});

expect(requests).toHaveLength(1);
Expand Down Expand Up @@ -802,7 +801,6 @@ describe('NetworkManager', () => {
requestId: 'LOADERID',
timestamp: 671.234448,
encodedDataLength: 197,
shouldReportCorbBlocking: false,
});

expect(pendingRequests).toHaveLength(1);
Expand Down Expand Up @@ -1115,7 +1113,6 @@ describe('NetworkManager', () => {
requestId: 'E18BEB94B486CA8771F9AFA2030FEA37',
timestamp: 510294.113383,
encodedDataLength: 197,
shouldReportCorbBlocking: false,
});
mockCDPSession.emit('Network.responseReceivedExtraInfo', {
requestId: 'E18BEB94B486CA8771F9AFA2030FEA37',
Expand Down Expand Up @@ -1283,7 +1280,6 @@ describe('NetworkManager', () => {
requestId: '6D76C8ACAECE880C722FA515AD380015',
timestamp: 31949.963861,
encodedDataLength: 847,
shouldReportCorbBlocking: false,
});

mockCDPSession.emit('Network.requestWillBeSent', {
Expand Down Expand Up @@ -1534,7 +1530,6 @@ describe('NetworkManager', () => {
requestId: '4C2CC44FB6A6CAC5BE2780BCC9313105',
timestamp: 31949.989412,
encodedDataLength: 0,
shouldReportCorbBlocking: false,
});
expect(
responses.map(r => {
Expand Down
2 changes: 1 addition & 1 deletion packages/puppeteer-core/src/revisions.ts
Expand Up @@ -18,6 +18,6 @@
* @internal
*/
export const PUPPETEER_REVISIONS = Object.freeze({
chrome: '116.0.5845.96',
chrome: '117.0.5938.62',
firefox: 'latest',
});
8 changes: 7 additions & 1 deletion test/TestExpectations.json
Expand Up @@ -1347,7 +1347,7 @@
"testIdPattern": "[accessibility.spec] Accessibility filtering children of leaf nodes rich text editable fields should have children",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "webDriverBiDi"],
"expectations": ["FAIL"]
"expectations": ["PASS"]
},
{
"testIdPattern": "[accessibility.spec] Accessibility get snapshots while the tree is re-calculated",
Expand Down Expand Up @@ -4084,5 +4084,11 @@
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "chrome", "headless"],
"expectations": ["FAIL", "PASS"]
},
{
"testIdPattern": "[coverage.spec] Coverage specs JSCoverage resetOnNavigation should report scripts across navigations when disabled",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "new-headless", "cdp", "tabTarget"],
"expectations": ["FAIL"]
}
]
2 changes: 1 addition & 1 deletion test/src/accessibility.spec.ts
Expand Up @@ -338,7 +338,7 @@ describe('Accessibility', function () {
name: 'Edit this image: ',
},
{
role: 'img',
role: 'image',
name: 'my fake image',
},
],
Expand Down
2 changes: 1 addition & 1 deletion test/src/ariaqueryhandler.spec.ts
Expand Up @@ -390,7 +390,7 @@ describe('AriaQueryHandler', () => {

let imgFound = false;
const waitForSelector = page
.waitForSelector('aria/[role="img"]')
.waitForSelector('aria/[role="image"]')
.then(() => {
return (imgFound = true);
});
Expand Down
3 changes: 2 additions & 1 deletion versions.js
Expand Up @@ -17,6 +17,7 @@
const versionsPerRelease = new Map([
// This is a mapping from Chrome version => Puppeteer version.
// In Chrome roll patches, use `NEXT` for the Puppeteer version.
['117.0.5938.62', 'NEXT'],
['116.0.5845.96', 'v21.1.0'],
['115.0.5790.170', 'v21.0.2'],
['115.0.5790.102', 'v21.0.0'],
Expand Down Expand Up @@ -65,7 +66,7 @@ const versionsPerRelease = new Map([
]);

// Should not be more than 2 major versions behind Chrome Stable (https://chromestatus.com/roadmap).
const lastMaintainedChromeVersion = '114.0.5735.90';
const lastMaintainedChromeVersion = '114.0.5735.133';

if (!versionsPerRelease.has(lastMaintainedChromeVersion)) {
throw new Error(
Expand Down

0 comments on commit 4b8d20d

Please sign in to comment.