chore: bump BiDi Mapper to latest (#10060)

puppeteer · Apr 24, 2023 · 513f658 · 513f658
1 parent e5d6864
commit 513f658
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 18 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -132,7 +132,7 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "dependencies": {
-    "chromium-bidi": "0.4.6",
+    "chromium-bidi": "0.4.7",
     "cross-fetch": "3.1.5",
     "debug": "4.3.4",
     "devtools-protocol": "0.0.1107588",

diff --git a/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts b/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts
@@ -106,9 +106,10 @@ class CDPConnectionAdapter {
  *
  * @internal
  */
-class CDPClientAdapter<
-  T extends Pick<CDPPPtrConnection, 'send' | 'on' | 'off'>
-> extends BidiMapper.EventEmitter<CdpEvents> {
+class CDPClientAdapter<T extends Pick<CDPPPtrConnection, 'send' | 'on' | 'off'>>
+  extends BidiMapper.EventEmitter<CdpEvents>
+  implements BidiMapper.CdpClient
+{
   #closed = false;
   #client: T;
 
@@ -157,17 +158,20 @@ class NoOpTransport
   extends BidiMapper.EventEmitter<any>
   implements BidiMapper.BidiTransport
 {
-  #onMessage: (message: Bidi.Message.RawCommandRequest) => Promise<void> =
-    async (_m: Bidi.Message.RawCommandRequest): Promise<void> => {
-      return;
-    };
+  #onMessage: (
+    message: Bidi.Message.RawCommandRequest
+  ) => Promise<void> | void = async (
+    _m: Bidi.Message.RawCommandRequest
+  ): Promise<void> => {
+    return;
+  };
 
   emitMessage(message: Bidi.Message.RawCommandRequest) {
     this.#onMessage(message);
   }
 
   setOnMessage(
-    onMessage: (message: Bidi.Message.RawCommandRequest) => Promise<void>
+    onMessage: (message: Bidi.Message.RawCommandRequest) => Promise<void> | void
   ): void {
     this.#onMessage = onMessage;
   }

diff --git a/test/TestSuites.json b/test/TestSuites.json
@@ -51,7 +51,8 @@
       "PUPPETEER_PRODUCT": "firefox"
     },
     "headless": {
-      "HEADLESS": "true"
+      "HEADLESS": "true",
+      "PUPPETEER_LOGLEVEL": "silent"
     },
     "headful": {
       "HEADLESS": "false"