chore: set allowViewportExpansion to captureBeyondViewport

puppeteer · Sep 22, 2023 · 53e2ceb · 53e2ceb
1 parent 18ba47e
commit 53e2ceb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/puppeteer-core/src/api/ElementHandle.ts b/packages/puppeteer-core/src/api/ElementHandle.ts
@@ -1338,7 +1338,7 @@ export abstract class ElementHandle<
     const {
       scrollIntoView = true,
       captureBeyondViewport = true,
-      allowViewportExpansion = true,
+      allowViewportExpansion = captureBeyondViewport,
     } = options;
 
     let clip = await this.#nonEmptyVisibleBoundingBox();
@@ -1347,7 +1347,7 @@ export abstract class ElementHandle<
 
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     await using _ =
-      (captureBeyondViewport || allowViewportExpansion) && clip
+      allowViewportExpansion && clip
         ? await page._createTemporaryViewportContainingBox(clip)
         : null;
 
@@ -1373,7 +1373,6 @@ export abstract class ElementHandle<
     return await page.screenshot({
       ...options,
       captureBeyondViewport: false,
-      allowViewportExpansion: false,
       clip,
     });
   }

diff --git a/packages/puppeteer-core/src/api/Page.ts b/packages/puppeteer-core/src/api/Page.ts
@@ -2351,7 +2351,7 @@ export abstract class Page extends EventEmitter<PageEvents> {
     }
 
     options.captureBeyondViewport ??= true;
-    options.allowViewportExpansion ??= true;
+    options.allowViewportExpansion ??= options.captureBeyondViewport;
     options.clip = options.clip && roundClip(normalizeClip(options.clip));
 
     await using stack = new AsyncDisposableStack();