Skip to content

Commit

Permalink
fix(executioncontext): follow up to properly adopt element handles (#…
Browse files Browse the repository at this point in the history
…3857)

The `executionContextId` argument was missing, which made all
element handles to resolve in the main world. All our tests pass
atm, but this would've fired back when we exposed extension
execution contexts.
  • Loading branch information
aslushnikov committed Jan 28, 2019
1 parent 55432f8 commit 63d9ac4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/ExecutionContext.js
Expand Up @@ -186,6 +186,7 @@ class ExecutionContext {
});
const {object} = await this._client.send('DOM.resolveNode', {
backendNodeId: nodeInfo.node.backendNodeId,
executionContextId: this._contextId,
});
return /** @type {Puppeteer.ElementHandle}*/(createJSHandle(this, object));
}
Expand Down

0 comments on commit 63d9ac4

Please sign in to comment.