chore: enable test for ff (#12037)

puppeteer · Mar 4, 2024 · 7284576 · 7284576
1 parent f3afc06
commit 7284576
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -47,12 +47,6 @@
     "parameters": ["webDriverBiDi"],
     "expectations": ["SKIP"]
   },
-  {
-    "testIdPattern": "[headful.spec] *",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["firefox"],
-    "expectations": ["SKIP"]
-  },
   {
     "testIdPattern": "[idle_override.spec] *",
     "platforms": ["darwin", "linux", "win32"],

diff --git a/test/src/headful.spec.ts b/test/src/headful.spec.ts
@@ -22,8 +22,8 @@ describe('headful tests', function () {
    */
   this.timeout(20_000);
 
-  let headfulOptions: PuppeteerLaunchOptions | undefined;
-  let headlessOptions: PuppeteerLaunchOptions & {headless: boolean};
+  let headfulOptions: PuppeteerLaunchOptions & {headless: false};
+  let headlessOptions: PuppeteerLaunchOptions & {headless: true};
 
   const browsers: Array<() => Promise<void>> = [];
 
@@ -32,10 +32,10 @@ describe('headful tests', function () {
       skipLaunch: true,
     });
     headfulOptions = Object.assign({}, defaultBrowserOptions, {
-      headless: false,
+      headless: false as const,
     });
     headlessOptions = Object.assign({}, defaultBrowserOptions, {
-      headless: true,
+      headless: true as const,
     });
   });