refactor: use http-proxy-agent (#10132)

puppeteer · May 4, 2023 · 7358e9e · 7358e9e
1 parent 8d08b2f
commit 7358e9e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/browsers/package.json b/packages/browsers/package.json
@@ -101,6 +101,7 @@
   "dependencies": {
     "debug": "4.3.4",
     "extract-zip": "2.0.1",
+    "http-proxy-agent": "5.0.0",
     "https-proxy-agent": "5.0.1",
     "progress": "2.0.3",
     "proxy-from-env": "1.1.0",

diff --git a/packages/browsers/src/httpUtil.ts b/packages/browsers/src/httpUtil.ts
@@ -19,6 +19,7 @@ import * as http from 'http';
 import * as https from 'https';
 import {URL} from 'url';
 
+import createHttpProxyAgent from 'http-proxy-agent';
 import createHttpsProxyAgent from 'https-proxy-agent';
 import {getProxyForUrl} from 'proxy-from-env';
 
@@ -57,12 +58,7 @@ export function httpRequest(
   if (proxyURL) {
     const proxy = new URL(proxyURL);
     if (proxy.protocol === 'http:') {
-      options.path = url.href;
-      options.hostname = proxy.hostname;
-      options.protocol = proxy.protocol;
-      options.port = proxy.port;
-      options.headers ??= {};
-      options.headers['Host'] ||= url.host;
+      options.agent = createHttpProxyAgent(proxyURL);
     } else {
       options.agent = createHttpsProxyAgent({
         host: proxy.host,