fix: expect Network.responseReceived event is never dispatched (#3233)

Fixes #2888.
puppeteer · Sep 12, 2018 · 7ec0801 · 7ec0801
1 parent c644a3b
commit 7ec0801
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/NetworkManager.js b/lib/NetworkManager.js
@@ -249,7 +249,11 @@ class NetworkManager extends EventEmitter {
     // @see https://crbug.com/750469
     if (!request)
       return;
-    request.response()._bodyLoadedPromiseFulfill.call(null);
+
+    // Under certain conditions we never get the Network.responseReceived
+    // event from protocol. @see https://crbug.com/883475
+    if (request.response())
+      request.response()._bodyLoadedPromiseFulfill.call(null);
     this._requestIdToRequest.delete(request._requestId);
     this._attemptedAuthentications.delete(request._interceptionId);
     this.emit(NetworkManager.Events.RequestFinished, request);