fix: update the target to ES2022 (#10574)

puppeteer · Jul 18, 2023 · 88439f9 · 88439f9
1 parent a419abf
commit 88439f9
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 18 deletions.
diff --git a/docs/api/puppeteer.jshandle.md b/docs/api/puppeteer.jshandle.md
@@ -28,9 +28,9 @@ const windowHandle = await page.evaluateHandle(() => window);
 
 ## Properties
 
-| Property               | Modifiers             | Type | Description                                                    |
-| ---------------------- | --------------------- | ---- | -------------------------------------------------------------- |
-| \[\_\_JSHandleSymbol\] | <code>optional</code> | T    | Used for nominally typing [JSHandle](./puppeteer.jshandle.md). |
+| Property | Modifiers             | Type | Description                                                    |
+| -------- | --------------------- | ---- | -------------------------------------------------------------- |
+| \_       | <code>optional</code> | T    | Used for nominally typing [JSHandle](./puppeteer.jshandle.md). |
 
 ## Methods
 

diff --git a/packages/puppeteer-core/src/api/JSHandle.ts b/packages/puppeteer-core/src/api/JSHandle.ts
@@ -22,8 +22,6 @@ import {EvaluateFuncWith, HandleFor, HandleOr} from '../common/types.js';
 
 import {ElementHandle} from './ElementHandle.js';
 
-declare const __JSHandleSymbol: unique symbol;
-
 /**
  * Represents a reference to a JavaScript object. Instances can be created using
  * {@link Page.evaluateHandle}.
@@ -49,7 +47,7 @@ export class JSHandle<T = unknown> {
   /**
    * Used for nominally typing {@link JSHandle}.
    */
-  [__JSHandleSymbol]?: T;
+  declare _?: T;
 
   /**
    * @internal

diff --git a/packages/puppeteer-core/src/common/Frame.ts b/packages/puppeteer-core/src/common/Frame.ts
@@ -31,7 +31,7 @@ import {
 } from './DeviceRequestPrompt.js';
 import {ExecutionContext} from './ExecutionContext.js';
 import {FrameManager} from './FrameManager.js';
-import {IsolatedWorld, IsolatedWorldChart} from './IsolatedWorld.js';
+import {IsolatedWorld} from './IsolatedWorld.js';
 import {MAIN_WORLD, PUPPETEER_WORLD} from './IsolatedWorlds.js';
 import {LazyArg} from './LazyArg.js';
 import {LifecycleWatcher, PuppeteerLifeCycleEvent} from './LifecycleWatcher.js';
@@ -46,11 +46,9 @@ export class Frame extends BaseFrame {
   #detached = false;
   #client!: CDPSession;
 
-  override worlds!: IsolatedWorldChart;
   _frameManager: FrameManager;
   override _id: string;
   _loaderId = '';
-  override _name?: string;
   override _hasStartedLoading = false;
   _lifecycleEvents = new Set<string>();
   override _parentId?: string;

diff --git a/packages/puppeteer-core/src/common/JSHandle.ts b/packages/puppeteer-core/src/common/JSHandle.ts
@@ -30,17 +30,10 @@ import {
   withSourcePuppeteerURLIfNone,
 } from './util.js';
 
-declare const __JSHandleSymbol: unique symbol;
-
 /**
  * @internal
  */
 export class CDPJSHandle<T = unknown> extends JSHandle<T> {
-  /**
-   * Used for nominally typing {@link JSHandle}.
-   */
-  [__JSHandleSymbol]?: T;
-
   #disposed = false;
   #context: ExecutionContext;
   #remoteObject: Protocol.Runtime.RemoteObject;

diff --git a/packages/puppeteer-core/src/common/WaitTask.ts b/packages/puppeteer-core/src/common/WaitTask.ts
@@ -228,7 +228,6 @@ export class WaitTask<T = unknown> {
       return error;
     }
 
-    // @ts-expect-error TODO: uncomment once cause is supported in Node types.
     return new Error('WaitTask failed with an error', {
       cause: error,
     });

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -26,7 +26,7 @@
     "strictFunctionTypes": true,
     "strictNullChecks": true,
     "strictPropertyInitialization": true,
-    "target": "ES2021",
+    "target": "ES2022",
     "useUnknownInCatchVariables": true,
     "skipLibCheck": true
   }