feat!: drop support for node16

puppeteer · Jan 16, 2024 · 8b496c2 · 8b496c2
1 parent 8b71db7
commit 8b496c2
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 27 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -335,7 +335,7 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 18
+          - lts/*
         pkg_manager:
           - npm
         os:

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/browsers/package.json b/packages/browsers/package.json
@@ -87,7 +87,7 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=16.3.0"
+    "node": ">=18.17.1"
   },
   "files": [
     "lib",

diff --git a/packages/ng-schematics/package.json b/packages/ng-schematics/package.json
@@ -48,7 +48,7 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=16.13.2"
+    "node": ">=18.17.1"
   },
   "dependencies": {
     "@angular-devkit/architect": "^0.1700.7",

diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -31,7 +31,7 @@
     "url": "https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer-core"
   },
   "engines": {
-    "node": ">=16.13.2"
+    "node": ">=18.17.1"
   },
   "scripts": {
     "build:docs": "wireit",

diff --git a/packages/puppeteer-core/src/common/BrowserConnector.ts b/packages/puppeteer-core/src/common/BrowserConnector.ts
@@ -14,7 +14,6 @@ import {isErrorLike} from '../util/ErrorLike.js';
 import type {ConnectionTransport} from './ConnectionTransport.js';
 import type {ConnectOptions} from './ConnectOptions.js';
 import type {BrowserConnectOptions} from './ConnectOptions.js';
-import {getFetch} from './fetch.js';
 
 const getWebSocketTransportClass = async () => {
   return isNode
@@ -93,9 +92,8 @@ async function getConnectionTransport(
 async function getWSEndpoint(browserURL: string): Promise<string> {
   const endpointURL = new URL('/json/version', browserURL);
 
-  const fetch = await getFetch();
   try {
-    const result = await fetch(endpointURL.toString(), {
+    const result = await globalThis.fetch(endpointURL.toString(), {
       method: 'GET',
     });
     if (!result.ok) {

diff --git a/packages/puppeteer-core/src/common/common.ts b/packages/puppeteer-core/src/common/common.ts
@@ -15,7 +15,6 @@ export * from './Debug.js';
 export * from './Device.js';
 export * from './Errors.js';
 export * from './EventEmitter.js';
-export * from './fetch.js';
 export * from './FileChooser.js';
 export * from './GetQueryHandler.js';
 export * from './HandleIterator.js';

diff --git a/packages/puppeteer-core/src/common/fetch.ts b/packages/puppeteer-core/src/common/fetch.ts
diff --git a/packages/puppeteer/package.json b/packages/puppeteer/package.json
@@ -32,7 +32,7 @@
     "url": "https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer"
   },
   "engines": {
-    "node": ">=16.13.2"
+    "node": ">=18.17.1"
   },
   "scripts": {
     "build:docs": "wireit",