Skip to content

Commit

Permalink
feat(Chromium): roll Chromium to r548153 (#2312)
Browse files Browse the repository at this point in the history
This roll includes:
- https://crrev.com/547982 - v8 roll that includes [fixed
  Runtime.callFunctionOn](https://chromium.googlesource.com/v8/v8/+/1637818671c66333e3a3cf1b96a7326ba163f8b5) method

The upstream fix makes it possible to run frame.waitFor* functions on
pages with strict CSP.

References #1229.
  • Loading branch information
aslushnikov committed Apr 4, 2018
1 parent f925158 commit 98093f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -36,7 +36,7 @@
"ws": "^3.0.0"
},
"puppeteer": {
"chromium_revision": "546920"
"chromium_revision": "548153"
},
"devDependencies": {
"@types/debug": "0.0.30",
Expand Down
2 changes: 1 addition & 1 deletion test/frame.spec.js
Expand Up @@ -110,7 +110,7 @@ module.exports.addTests = function({testRunner, expect}) {
await page.evaluate(() => window.__FOO = 'hit');
await watchdog;
});
xit('should work with strict CSP policy', async({page, server}) => {
it('should work with strict CSP policy', async({page, server}) => {
server.setCSP('/empty.html', 'script-src ' + server.PREFIX);
await page.goto(server.EMPTY_PAGE);
const watchdog = page.waitForFunction(() => window.__FOO === 'hit', {polling: 'raf'});
Expand Down
2 changes: 1 addition & 1 deletion test/target.spec.js
Expand Up @@ -131,4 +131,4 @@ module.exports.addTests = function({testRunner, expect}) {
await newPage.close();
});
});
};
};

0 comments on commit 98093f0

Please sign in to comment.