fix: use supported node range for types

Using the supported node range for types ensures Puppeteer compiles to the correct types.
puppeteer · Sep 13, 2023 · a4f0403 · a4f0403
1 parent 2fb0032
commit a4f0403
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 31 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -118,7 +118,7 @@
     "@types/diff": "5.0.3",
     "@types/mime": "3.0.1",
     "@types/mocha": "10.0.1",
-    "@types/node": "20.5.9",
+    "@types/node": "16.3.0",
     "@types/pixelmatch": "5.2.4",
     "@types/pngjs": "6.0.1",
     "@types/progress": "2.0.5",

diff --git a/packages/browsers/package.json b/packages/browsers/package.json
@@ -106,7 +106,6 @@
     "yargs": "17.7.1"
   },
   "devDependencies": {
-    "@types/node": "^16.11.7",
     "@types/yargs": "17.0.22"
   }
 }
diff --git a/packages/puppeteer-core/third_party/disposablestack/disposablestack.ts b/packages/puppeteer-core/third_party/disposablestack/disposablestack.ts
@@ -1,6 +1,26 @@
 import 'disposablestack/auto';
 
 declare global {
+  interface SymbolConstructor {
+    /**
+     * A method that is used to release resources held by an object. Called by the semantics of the `using` statement.
+     */
+    readonly dispose: unique symbol;
+
+    /**
+     * A method that is used to asynchronously release resources held by an object. Called by the semantics of the `await using` statement.
+     */
+    readonly asyncDispose: unique symbol;
+  }
+
+  interface Disposable {
+    [Symbol.dispose](): void;
+  }
+
+  interface AsyncDisposable {
+    [Symbol.asyncDispose](): PromiseLike<void>;
+  }
+
   class DisposableStack implements Disposable {
     constructor();