perf: amortize handle iterator (#10002)

puppeteer · Apr 11, 2023 · ab27f73 · ab27f73
1 parent dba1b2d
commit ab27f73
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/puppeteer-core/src/common/HandleIterator.ts b/packages/puppeteer-core/src/common/HandleIterator.ts
@@ -29,7 +29,7 @@ const DEFAULT_BATCH_SIZE = 20;
  */
 async function* fastTransposeIteratorHandle<T>(
   iterator: JSHandle<AwaitableIterator<T>>,
-  size = DEFAULT_BATCH_SIZE
+  size: number
 ) {
   const array = await iterator.evaluateHandle(async (iterator, size) => {
     const results = [];
@@ -56,8 +56,11 @@ async function* fastTransposeIteratorHandle<T>(
 async function* transposeIteratorHandle<T>(
   iterator: JSHandle<AwaitableIterator<T>>
 ) {
+  let size = DEFAULT_BATCH_SIZE;
   try {
-    while (!(yield* fastTransposeIteratorHandle(iterator))) {}
+    while (!(yield* fastTransposeIteratorHandle(iterator, size))) {
+      size <<= 1;
+    }
   } finally {
     await iterator.dispose();
   }