fix: continue requests without network instrumentation

puppeteer · Apr 19, 2023 · ad7cc4c · ad7cc4c
1 parent 5547e43
commit ad7cc4c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/packages/puppeteer-core/src/common/NetworkManager.ts b/packages/puppeteer-core/src/common/NetworkManager.ts
@@ -336,6 +336,11 @@ export class NetworkManager extends EventEmitter {
     const {networkId: networkRequestId, requestId: fetchRequestId} = event;
 
     if (!networkRequestId) {
+      this.#client
+        .send('Fetch.continueRequest', {
+          requestId: event.requestId,
+        })
+        .catch(debugError);
       return;
     }
 

diff --git a/test/src/requestinterception.spec.ts b/test/src/requestinterception.spec.ts
@@ -127,6 +127,18 @@ describe('request interception', function () {
       expect(requests[1]!.url()).toContain('/one-style.css');
       expect(requests[1]!.headers()['referer']).toContain('/one-style.html');
     });
+    it('should work with requests without networkId', async () => {
+      const {page, server} = getTestState();
+      await page.goto(server.EMPTY_PAGE);
+      await page.setRequestInterception(true);
+      page.on('request', request => {
+        return request.continue();
+      });
+      const cdp = await page.target().createCDPSession();
+      await cdp.send('DOM.enable');
+      // This causes network requests without networkId.
+      await cdp.send('CSS.enable');
+    });
     it('should properly return navigation response when URL has cookies', async () => {
       const {page, server} = getTestState();