build: fix windows build

puppeteer · Feb 22, 2024 · b06c257 · b06c257
1 parent 5e942b3
commit b06c257
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/packages/puppeteer-core/Herebyfile.mjs b/packages/puppeteer-core/Herebyfile.mjs
@@ -5,7 +5,8 @@
  */
 import {mkdir, readFile, readdir, writeFile} from 'fs/promises';
 import Module from 'node:module';
-import {join, dirname} from 'path/posix';
+import path from 'path';
+import posixPath from 'path/posix';
 
 import esbuild from 'esbuild';
 import {execa} from 'execa';
@@ -99,13 +100,13 @@ export const buildTask = task({
       });
     const builders = [];
     for (const format of formats) {
-      const folder = join('lib', format, 'third_party');
+      const folder = posixPath.join('lib', format, 'third_party');
       for (const name of packages) {
-        const path = join(folder, name, `${name}.js`);
+        const entrypoint = posixPath.join(folder, name, `${name}.js`);
         builders.push(
           await esbuild.build({
-            entryPoints: [path],
-            outfile: path,
+            entryPoints: [entrypoint],
+            outfile: entrypoint,
             bundle: true,
             allowOverwrite: true,
             format,
@@ -118,13 +119,18 @@ export const buildTask = task({
         switch (name) {
           case 'rxjs':
             license = await readFile(
-              `${dirname(require.resolve('rxjs'))}/../../LICENSE.txt`,
+              path.join(
+                path.dirname(require.resolve('rxjs')),
+                '..',
+                '..',
+                'LICENSE.txt'
+              ),
               'utf-8'
             );
             break;
           case 'mitt':
             license = await readFile(
-              `${dirname(require.resolve('mitt'))}/../LICENSE`,
+              path.join(path.dirname(require.resolve('mitt')), '..', 'LICENSE'),
               'utf-8'
             );
             break;