Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r818858 (#6526)
Browse files Browse the repository at this point in the history
This corresponds to Chromium 88.0.4298.0.

This roll includes:

- DevTools: Wait for a frame before sending touch and wheel events
  https://chromium-review.googlesource.com/c/chromium/src/+/2437695
  • Loading branch information
JoelEinbinder authored and mathiasbynens committed Oct 27, 2020
1 parent d3d7cb9 commit b549256
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"license": "Apache-2.0",
"dependencies": {
"debug": "^4.1.0",
"devtools-protocol": "0.0.809251",
"devtools-protocol": "0.0.818844",
"extract-zip": "^2.0.0",
"https-proxy-agent": "^4.0.0",
"node-fetch": "^2.6.1",
Expand Down
9 changes: 0 additions & 9 deletions src/common/Input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -510,15 +510,6 @@ export class Touchscreen {
* @param y - Vertical position of the tap.
*/
async tap(x: number, y: number): Promise<void> {
// Touches appear to be lost during the first frame after navigation.
// This waits a frame before sending the tap.
// @see https://crbug.com/613219
await this._client.send('Runtime.evaluate', {
expression:
'new Promise(x => requestAnimationFrame(() => requestAnimationFrame(x)))',
awaitPromise: true,
});

const touchPoints = [{ x: Math.round(x), y: Math.round(y) }];
await this._client.send('Input.dispatchTouchEvent', {
type: 'touchStart',
Expand Down
2 changes: 1 addition & 1 deletion src/revisions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ type Revisions = Readonly<{
}>;

export const PUPPETEER_REVISIONS: Revisions = {
chromium: '809590',
chromium: '818858',
firefox: 'latest',
};

0 comments on commit b549256

Please sign in to comment.