feat(api): add Page.isJavaScriptEnabled + mark properties as private (#…

…5993) Just one was used externally and I wrapped that up in a method. I think it's a useful method to provide (I can imagine wanting to know if JS is enabled on a page) so I think there's no harm here (I'd rather that then have JSHandle reach into a private variable).
puppeteer · Jun 10, 2020 · b86ff21 · b86ff21
1 parent 354f942
commit b86ff21
Show file tree

Hide file tree

Showing 33 changed files with 50 additions and 465 deletions.
diff --git a/docs/api.md b/docs/api.md
@@ -131,6 +131,7 @@
   * [page.goto(url[, options])](#pagegotourl-options)
   * [page.hover(selector)](#pagehoverselector)
   * [page.isClosed()](#pageisclosed)
+  * [page.isJavaScriptEnabled()](#pageisjavascriptenabled)
   * [page.keyboard](#pagekeyboard)
   * [page.mainFrame()](#pagemainframe)
   * [page.metrics()](#pagemetrics)
@@ -1643,6 +1644,12 @@ Shortcut for [page.mainFrame().hover(selector)](#framehoverselector).
 
 Indicates that the page has been closed.
 
+#### page.isJavaScriptEnabled()
+
+- returns: <[boolean]>
+
+Returns `true` if the page has JavaScript enabled, `false` otherwise.
+
 #### page.keyboard
 
 - returns: <[Keyboard]>

diff --git a/new-docs/puppeteer.page._accessibility.md b/new-docs/puppeteer.page._accessibility.md
diff --git a/new-docs/puppeteer.page._addconsolemessage.md b/new-docs/puppeteer.page._addconsolemessage.md
diff --git a/new-docs/puppeteer.page._buildmetricsobject.md b/new-docs/puppeteer.page._buildmetricsobject.md
diff --git a/new-docs/puppeteer.page._client.md b/new-docs/puppeteer.page._client.md
diff --git a/new-docs/puppeteer.page._closed.md b/new-docs/puppeteer.page._closed.md
diff --git a/new-docs/puppeteer.page._coverage.md b/new-docs/puppeteer.page._coverage.md
diff --git a/new-docs/puppeteer.page._disconnectpromise.md b/new-docs/puppeteer.page._disconnectpromise.md
diff --git a/new-docs/puppeteer.page._emitmetrics.md b/new-docs/puppeteer.page._emitmetrics.md
diff --git a/new-docs/puppeteer.page._emulationmanager.md b/new-docs/puppeteer.page._emulationmanager.md
diff --git a/new-docs/puppeteer.page._filechooserinterceptors.md b/new-docs/puppeteer.page._filechooserinterceptors.md
diff --git a/new-docs/puppeteer.page._framemanager.md b/new-docs/puppeteer.page._framemanager.md
diff --git a/new-docs/puppeteer.page._handleexception.md b/new-docs/puppeteer.page._handleexception.md
diff --git a/new-docs/puppeteer.page._javascriptenabled.md b/new-docs/puppeteer.page._javascriptenabled.md
diff --git a/new-docs/puppeteer.page._keyboard.md b/new-docs/puppeteer.page._keyboard.md
diff --git a/new-docs/puppeteer.page._mouse.md b/new-docs/puppeteer.page._mouse.md
diff --git a/new-docs/puppeteer.page._onbindingcalled.md b/new-docs/puppeteer.page._onbindingcalled.md
diff --git a/new-docs/puppeteer.page._onconsoleapi.md b/new-docs/puppeteer.page._onconsoleapi.md
diff --git a/new-docs/puppeteer.page._ondialog.md b/new-docs/puppeteer.page._ondialog.md
diff --git a/new-docs/puppeteer.page._onfilechooser.md b/new-docs/puppeteer.page._onfilechooser.md
diff --git a/new-docs/puppeteer.page._pagebindings.md b/new-docs/puppeteer.page._pagebindings.md
diff --git a/new-docs/puppeteer.page._screenshottaskqueue.md b/new-docs/puppeteer.page._screenshottaskqueue.md
diff --git a/new-docs/puppeteer.page._sessionclosepromise.md b/new-docs/puppeteer.page._sessionclosepromise.md
diff --git a/new-docs/puppeteer.page._target.md b/new-docs/puppeteer.page._target.md