fix: correctly parse the default buildId (#10535)

puppeteer · Jul 11, 2023 · c308266 · c308266
1 parent 19111be
commit c308266
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/browsers/src/CLI.ts b/packages/browsers/src/CLI.ts
@@ -274,7 +274,8 @@ export class CLI {
   }
 
   #parseBuildId(version: string): string {
-    return version.split('@').pop() ?? 'latest';
+    const parts = version.split('@');
+    return parts.length === 2 ? parts[1]! : 'latest';
   }
 }
 

diff --git a/packages/browsers/test/src/firefox/cli.spec.ts b/packages/browsers/test/src/firefox/cli.spec.ts
@@ -75,5 +75,15 @@ describe('Firefox CLI', function () {
       '--platform=linux',
       `--base-url=${getServerUrl()}`,
     ]);
+
+    await new CLI(tmpDir).run([
+      'npx',
+      '@puppeteer/browsers',
+      'install',
+      `firefox`,
+      `--path=${tmpDir}`,
+      '--platform=linux',
+      `--base-url=${getServerUrl()}`,
+    ]);
   });
 });