fix(Page): fix Page.evaluate with Symbols in arrays (#2340)

Fixes #2295.
puppeteer · Apr 10, 2018 · c5902de · c5902de
1 parent 5d106f7
commit c5902de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/ExecutionContext.js b/lib/ExecutionContext.js
@@ -47,6 +47,8 @@ class ExecutionContext {
     const result = await handle.jsonValue().catch(error => {
       if (error.message.includes('Object reference chain is too long'))
         return;
+      if (error.message.includes('Object couldn\'t be returned by value'))
+        return;
       throw error;
     });
     await handle.dispose();

diff --git a/test/page.spec.js b/test/page.spec.js
@@ -124,9 +124,9 @@ module.exports.addTests = function({testRunner, expect, puppeteer, DeviceDescrip
     it('should properly serialize null fields', async({page}) => {
       expect(await page.evaluate(() => ({a: undefined}))).toEqual({});
     });
-    it('should fail for window object', async({page, server}) => {
-      const result = await page.evaluate(() => window);
-      expect(result).toBe(undefined);
+    it('should return undefined for non-serializable objects', async({page, server}) => {
+      expect(await page.evaluate(() => window)).toBe(undefined);
+      expect(await page.evaluate(() => [Symbol('foo4')])).toBe(undefined);
     });
     it('should fail for circular object', async({page, server}) => {
       const result = await page.evaluate(() => {