fix: make chromium-bidi an opt peer dep (#9667)

puppeteer · Feb 14, 2023 · c6054ac · c6054ac
1 parent eb13863
commit c6054ac
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -131,7 +131,6 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "dependencies": {
-    "chromium-bidi": "0.4.3",
     "cross-fetch": "3.1.5",
     "debug": "4.3.4",
     "devtools-protocol": "0.0.1094867",
@@ -144,11 +143,15 @@
     "ws": "8.11.0"
   },
   "peerDependencies": {
-    "typescript": ">= 4.7.4"
+    "typescript": ">= 4.7.4",
+    "chromium-bidi": "0.4.3"
   },
   "peerDependenciesMeta": {
     "typescript": {
       "optional": true
+    },
+    "chromium-bidi": {
+      "optional": true
     }
   }
 }
diff --git a/packages/puppeteer-core/src/node/BrowserRunner.ts b/packages/puppeteer-core/src/node/BrowserRunner.ts
@@ -262,7 +262,9 @@ export class BrowserRunner {
     );
     browserWSEndpoint += '/session';
     const transport = await WebSocketTransport.create(browserWSEndpoint);
-    const BiDi = await import('../common/bidi/bidi.js');
+    const BiDi = await import(
+      /* webpackIgnore: true */ '../common/bidi/bidi.js'
+    );
     return new BiDi.Connection(transport, slowMo);
   }
 

diff --git a/packages/puppeteer-core/src/node/ChromeLauncher.ts b/packages/puppeteer-core/src/node/ChromeLauncher.ts
@@ -129,7 +129,9 @@ export class ChromeLauncher extends ProductLauncher {
 
       if (protocol === 'webDriverBiDi') {
         try {
-          const BiDi = await import('../common/bidi/bidi.js');
+          const BiDi = await import(
+            /* webpackIgnore: true */ '../common/bidi/bidi.js'
+          );
           const bidiConnection = await BiDi.connectBidiOverCDP(connection);
           browser = await BiDi.Browser.create({
             connection: bidiConnection,

diff --git a/packages/puppeteer-core/src/node/FirefoxLauncher.ts b/packages/puppeteer-core/src/node/FirefoxLauncher.ts
@@ -131,7 +131,9 @@ export class FirefoxLauncher extends ProductLauncher {
           slowMo,
           preferredRevision: this.puppeteer.browserRevision,
         });
-        const BiDi = await import('../common/bidi/bidi.js');
+        const BiDi = await import(
+          /* webpackIgnore: true */ '../common/bidi/bidi.js'
+        );
         browser = await BiDi.Browser.create({
           connection,
           closeCallback: runner.close.bind(runner),