Skip to content

Commit

Permalink
fix(page): properly create isolated worlds (#4707)
Browse files Browse the repository at this point in the history
The following error:
```
Error: Protocol error (Page.createIsolatedWorld): No frame for given id found
```

was mentioned here:
FlowCrypt/flowcrypt-browser#1799 (comment)

This indeed seems to be a bug with our creation of isolated worlds.
  • Loading branch information
aslushnikov committed Jul 16, 2019
1 parent a39d553 commit c9977c8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/FrameManager.js
Expand Up @@ -15,7 +15,7 @@
*/

const EventEmitter = require('events');
const {helper, assert} = require('./helper');
const {helper, assert, debugError} = require('./helper');
const {Events} = require('./Events');
const {ExecutionContext, EVALUATION_SCRIPT_URL} = require('./ExecutionContext');
const {LifecycleWatcher} = require('./LifecycleWatcher');
Expand Down Expand Up @@ -276,7 +276,7 @@ class FrameManager extends EventEmitter {
frameId: frame._id,
grantUniveralAccess: true,
worldName: name,
})));
}).catch(debugError))); // frames might be removed before we send this
}

/**
Expand Down

0 comments on commit c9977c8

Please sign in to comment.