Skip to content

Commit

Permalink
Roll chromium to r496140 (#465)
Browse files Browse the repository at this point in the history
This patch rolls chromium to r496140. This includes the r496130 that
introduces multiple sessions for single target.

With this patch, it is possible to run puppeteer in headful mode
and open devtools over the automated pages without puppeteer losing
connection to the page.
  • Loading branch information
aslushnikov committed Aug 22, 2017
1 parent 11e3343 commit ce08fc7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions lib/Launcher.js
Expand Up @@ -37,6 +37,7 @@ const DEFAULT_ARGS = [
'--disable-prompt-on-repost',
'--disable-sync',
'--enable-automation',
'--enable-devtools-experiments',
'--metrics-recording-only',
'--no-first-run',
'--password-store=basic',
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -29,7 +29,7 @@
"ws": "^3.0.0"
},
"puppeteer": {
"chromium_revision": "494755"
"chromium_revision": "496140"
},
"devDependencies": {
"commonmark": "^0.27.0",
Expand Down
2 changes: 1 addition & 1 deletion test/test.js
Expand Up @@ -562,7 +562,7 @@ describe('Page', function() {
it('should fail when main resources failed to load', SX(async function() {
let error = null;
try {
await page.goto('chrome-devtools://non-existing.html');
await page.goto('http://localhost:44123/non-existing-url');
} catch (e) {
error = e;
}
Expand Down

0 comments on commit ce08fc7

Please sign in to comment.