Apply suggestions from code review

Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
puppeteer · Oct 23, 2023 · d6a53b7 · d6a53b7
1 parent 65c165f
commit d6a53b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -1692,22 +1692,10 @@
     "expectations": ["FAIL"]
   },
   {
-    "testIdPattern": "[device-request-prompt.spec] device request prompt can be cancelled",
+    "testIdPattern": "[device-request-prompt.spec] *",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["chrome", "headless"],
-    "expectations": ["FAIL"]
-  },
-  {
-    "testIdPattern": "[device-request-prompt.spec] device request prompt can be opened",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["chrome", "headless"],
-    "expectations": ["FAIL"]
-  },
-  {
-    "testIdPattern": "[device-request-prompt.spec] device request prompt waitForDevice does not crash",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["chrome", "headless"],
-    "expectations": ["FAIL"]
+    "expectations": ["SKIP"]
   },
   {
     "testIdPattern": "[dialog.spec] Page.Events.Dialog should allow accepting prompts",

diff --git a/test/src/device-request-prompt.spec.ts b/test/src/device-request-prompt.spec.ts
@@ -22,7 +22,7 @@ describe('device request prompt', function () {
   this.timeout(1_000);
   let state: Awaited<ReturnType<typeof launch>>;
 
-  before(async () => {
+  before(async function () {
     this.timeout(10_000);
     state = await launch(
       {