test: re-enable Firefox BiDi tests on MacOS (#11596)

puppeteer · Jan 4, 2024 · db986ad · db986ad
1 parent 5d69ccb
commit db986ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -246,10 +246,6 @@ jobs:
             suite: firefox-headful
           - os: macos-latest
             suite: firefox-headless
-          # Disabled due to https://bugzilla.mozilla.org/show_bug.cgi?id=1843550
-          # The first time the browsers launches it crashes.
-          - os: macos-latest
-            suite: firefox-bidi
           - os: windows-latest
             suite: firefox-headful
           - os: windows-latest

diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -2071,6 +2071,12 @@
     "parameters": ["cdp", "chrome"],
     "expectations": ["FAIL"]
   },
+  {
+    "testIdPattern": "[keyboard.spec] Keyboard should report shiftKey",
+    "platforms": ["darwin"],
+    "parameters": ["firefox", "webDriverBiDi"],
+    "expectations": ["FAIL"]
+  },
   {
     "testIdPattern": "[keyboard.spec] Keyboard should send a character with sendCharacter",
     "platforms": ["darwin", "linux", "win32"],
@@ -2357,7 +2363,7 @@
     "testIdPattern": "[navigation.spec] navigation Frame.waitForNavigation should work",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["firefox", "webDriverBiDi"],
-    "expectations": ["FAIL", "PASS"]
+    "expectations": ["FAIL", "PASS", "TIMEOUT"]
   },
   {
     "testIdPattern": "[navigation.spec] navigation Page.goBack should work with HistoryAPI",
@@ -3832,7 +3838,7 @@
   },
   {
     "testIdPattern": "[screenshot.spec] Screenshots ElementHandle.screenshot should capture full element when larger than viewport",
-    "platforms": ["win32"],
+    "platforms": ["darwin", "win32"],
     "parameters": ["firefox", "headless", "webDriverBiDi"],
     "expectations": ["FAIL"]
   },