Skip to content

Commit

Permalink
chore(doclint): fix doclint tests (#941)
Browse files Browse the repository at this point in the history
Last commit 017429e broke doclint
tests. Try bots didn't catch this because they were not running doclint
tests.

This patch:
- fixes doclint tests
- starts running doclint tests on travis
  • Loading branch information
aslushnikov committed Oct 2, 2017
1 parent 017429e commit dc4c878
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 11 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -15,6 +15,7 @@ install:
script:
- 'if [ "$NODE7" = "true" ]; then yarn run lint; fi'
- 'if [ "$NODE7" = "true" ]; then yarn run coverage; fi'
- 'if [ "$NODE7" = "true" ]; then yarn run test-doclint; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run test-node6-transformer; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run build; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run unit-node6; fi'
Expand Down
2 changes: 0 additions & 2 deletions utils/doclint/check_public_api/test/check-sorting/doc.md
Expand Up @@ -10,8 +10,6 @@

#### foo.ddd

#### new Foo()

#### foo.ccc()

#### foo.bbb()
3 changes: 1 addition & 2 deletions utils/doclint/check_public_api/test/check-sorting/result.txt
@@ -1,5 +1,4 @@
[MarkDown] Events should go first. Event 'b' in class Foo breaks order
[MarkDown] Constructor of Foo should go before other methods
[MarkDown] Event 'c' in class Foo breaks alphabetic ordering of events
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.constructor()
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.ccc()
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ccc() should go after Foo.bbb()
8 changes: 4 additions & 4 deletions utils/doclint/check_public_api/test/diff-arguments/doc.md
@@ -1,11 +1,11 @@
### class: Foo
#### new Foo(arg1, arg2)
- `arg1` <[string]>
- `arg2` <[string]>

#### foo.bar(options)
- `options` <[Object]>

#### foo.foo(arg1, arg2)
- `arg1` <[string]>
- `arg2` <[string]>

#### foo.test(...files)
- `...filePaths` <[string]>

2 changes: 1 addition & 1 deletion utils/doclint/check_public_api/test/diff-arguments/foo.js
@@ -1,5 +1,5 @@
class Foo {
constructor(arg1, arg3 = {}) {
foo(arg1, arg3 = {}) {
}

test(...filePaths) {
Expand Down
@@ -1,4 +1,4 @@
[MarkDown] Heading arguments for "foo.test(...files)" do not match described ones, i.e. "...files" != "...filePaths"
[MarkDown] Method Foo.constructor() fails to describe its parameters:
[MarkDown] Method Foo.foo() fails to describe its parameters:
- Argument not found: arg3
- Non-existing argument found: arg2
@@ -1,3 +1,2 @@
[MarkDown] Method not found: Foo.constructor()
[MarkDown] Non-existing property found: Foo.c
[MarkDown] Property not found: Foo.b

0 comments on commit dc4c878

Please sign in to comment.