fix(a11y): query only unignored nodes (#12224)

puppeteer · Apr 5, 2024 · e20cd64 · e20cd64
1 parent a63b830
commit e20cd64
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/packages/puppeteer-core/src/cdp/AriaQueryHandler.ts b/packages/puppeteer-core/src/cdp/AriaQueryHandler.ts
@@ -27,7 +27,16 @@ const queryAXTree = async (
     role,
   });
   return nodes.filter((node: Protocol.Accessibility.AXNode) => {
-    return !node.role || !NON_ELEMENT_NODE_ROLES.has(node.role.value);
+    if (node.ignored) {
+      return false;
+    }
+    if (!node.role) {
+      return false;
+    }
+    if (NON_ELEMENT_NODE_ROLES.has(node.role.value)) {
+      return false;
+    }
+    return true;
   });
 };