feat: roll to Chrome 124.0.6367.60 (r1274542) (#12305)

Co-authored-by: Alex Rudenko <alexrudenko@chromium.org>
puppeteer · Apr 23, 2024 · ed9d7dd · ed9d7dd
1 parent 2968f21
commit ed9d7dd
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 22 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -122,7 +122,7 @@
     "@puppeteer/browsers": "2.2.2",
     "chromium-bidi": "0.5.17",
     "debug": "4.3.4",
-    "devtools-protocol": "0.0.1262051",
+    "devtools-protocol": "0.0.1273771",
     "ws": "8.16.0"
   },
   "devDependencies": {

diff --git a/packages/puppeteer-core/src/revisions.ts b/packages/puppeteer-core/src/revisions.ts
@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '123.0.6312.122',
-  'chrome-headless-shell': '123.0.6312.122',
+  chrome: '124.0.6367.60',
+  'chrome-headless-shell': '124.0.6367.60',
   firefox: 'latest',
 });
diff --git a/packages/puppeteer/package.json b/packages/puppeteer/package.json
@@ -126,7 +126,7 @@
     "cosmiconfig": "9.0.0",
     "puppeteer-core": "22.6.5",
     "@puppeteer/browsers": "2.2.2",
-    "devtools-protocol": "0.0.1262051"
+    "devtools-protocol": "0.0.1273771"
   },
   "devDependencies": {
     "@types/node": "18.17.15"

diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -951,13 +951,6 @@
     "expectations": ["SKIP"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
-  {
-    "testIdPattern": "[accessibility.spec] Accessibility should work",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["chrome", "webDriverBiDi"],
-    "expectations": ["FAIL"],
-    "comment": "Change in A11Y tree on Canary"
-  },
   {
     "testIdPattern": "[ariaqueryhandler.spec] AriaQueryHandler queryAllArray $$eval should handle many elements",
     "platforms": ["darwin", "linux", "win32"],

diff --git a/test/src/accessibility.spec.ts b/test/src/accessibility.spec.ts
@@ -98,8 +98,8 @@ describe('Accessibility', function () {
               value: 'First Option',
               haspopup: 'menu',
               children: [
-                {role: 'menuitem', name: 'First Option', selected: true},
-                {role: 'menuitem', name: 'Second Option'},
+                {role: 'option', name: 'First Option', selected: true},
+                {role: 'option', name: 'Second Option'},
               ],
             },
           ],

diff --git a/versions.js b/versions.js
@@ -7,6 +7,7 @@
 const versionsPerRelease = new Map([
   // This is a mapping from Chrome version => Puppeteer version.
   // In Chrome roll patches, use `NEXT` for the Puppeteer version.
+  ['124.0.6367.60', 'NEXT'],
   ['123.0.6312.122', 'v22.6.4'],
   ['123.0.6312.105', 'v22.6.3'],
   ['123.0.6312.86', 'v22.6.2'],
@@ -71,7 +72,7 @@ const versionsPerRelease = new Map([
 ]);
 
 // Should not be more than 2 major versions behind Chrome Stable (https://chromestatus.com/roadmap).
-const lastMaintainedChromeVersion = '120.0.6099.109';
+const lastMaintainedChromeVersion = '121.0.6167.85';
 
 if (!versionsPerRelease.has(lastMaintainedChromeVersion)) {
   throw new Error(