test(firefox): run puppeteer-firefox tests in browser contexts (#3887)

This patch starts running all Puppeteer-Firefox tests in separate browser contexts.
puppeteer · Feb 1, 2019 · fd67fa7 · fd67fa7
1 parent bd34755
commit fd67fa7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/experimental/puppeteer-firefox/package.json b/experimental/puppeteer-firefox/package.json
@@ -8,7 +8,7 @@
     "node": ">=8.9.4"
   },
   "puppeteer": {
-    "firefox_revision": "2a2b2cd2c5e5b7062e7ede93b235a5a062d4dc9a"
+    "firefox_revision": "ca4758c475a9c05dc88b7b8811fbbb7e5acf95b4"
   },
   "scripts": {
     "install": "node install.js",

diff --git a/experimental/puppeteer-firefox/test/puppeteer.spec.js b/experimental/puppeteer-firefox/test/puppeteer.spec.js
@@ -63,11 +63,13 @@ module.exports.addTests = ({testRunner, product, puppeteer}) => testRunner.descr
 
     describe('Page', () => {
       beforeEach(async state => {
-        state.page = await state.browser.newPage();
+        state.context = await state.browser.createIncognitoBrowserContext();
+        state.page = await state.context.newPage();
       });
 
       afterEach(async state => {
-        await state.page.close();
+        await state.context.close();
+        state.context = null;
         state.page = null;
       });