chore: fix doclint violations (#6849)

puppeteer · Feb 9, 2021 · fd85747 · fd85747
1 parent f718b14
commit fd85747
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
     "eslint": "([ \"$CI\" = true ] && eslint --ext js --ext ts --quiet -f codeframe . || eslint --ext js --ext ts .)",
     "eslint-fix": "eslint --ext js --ext ts --fix .",
     "commitlint": "commitlint --from=HEAD~1",
-    "lint": "npm run eslint && npm run tsc && npm run doc && npm run commitlint",
+    "lint": "npm run eslint && npm run build && npm run doc && npm run commitlint",
     "doc": "node utils/doclint/cli.js",
     "clean-lib": "rm -rf lib",
     "build": "npm run tsc && npm run generate-d-ts",

diff --git a/utils/doclint/check_public_api/index.js b/utils/doclint/check_public_api/index.js
@@ -842,6 +842,21 @@ function compareDocumentations(actual, expected) {
           expectedName: 'ConnectOptions',
         },
       ],
+      [
+        'Method Page.deleteCookie() ...cookies',
+        {
+          actualName: '...Object',
+          expectedName: '...DeleteCookiesRequest',
+        },
+      ],
+      [
+        'Method Page.emulateVisionDeficiency() type',
+        {
+          actualName: 'string',
+          expectedName:
+            '"none"|"achromatopsia"|"blurredVision"|"deuteranopia"|"protanopia"|"tritanopia"',
+        },
+      ],
     ]);
 
     const expectedForSource = expectedNamingMismatches.get(source);