New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: switch to Chrome for Testing instead of Chromium #10054
Conversation
b3ad62c
to
674ab69
Compare
9e454a2
to
0937d62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clear summary in the PR description, and for making the changes in the first place! Nice work.
0937d62
to
ead6b43
Compare
2def08a
to
3573863
Compare
5016551
to
e600197
Compare
Trying a different CfT version to see if PDF on Windows still has issues. Do not land please. |
17e1cdb
to
eb7450c
Compare
@kblok where do you see that? we renamed from |
@OrKoN oh, sorry. My bad. Removing the comment to avoid confusion. Thank you! |
* chore(deps): bump puppeteer from 19.11.1 to 20.0.0 Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.11.1 to 20.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v19.11.1...puppeteer-v20.0.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix: use `PUPPETEER_SKIP_DOWNLOAD` ref: puppeteer/puppeteer#10054 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@OrKoN I'm currently installing the chromium package in my Debian environment to get the chromium binary needed for puppeteer. The reason I'm installing it myself, rather than relying on the binary bundled with puppeteer, is because puppeteer doesn't provide one for arm64. It doesn't seem like there's a "chrome for testing" package for Debian, or even a "chrome" package. Can we continue to use the chromium binary? Or any thoughts on how I would go about installing the relevant "chrome for testing" binary on Debian? |
@drmrbrewer you can use Chromium, but we won't test with Chromium builds anymore. We are working on getting arm64 for Chrome for Testing but I cannot give an estimate. |
@OrKoN OK thanks. That linked issue for arm64 has been open for 18 months now, and has collected over 70 thumbs-up votes, so it seems like there is a need... and this move to "chrome for testing" makes it even more pressing now, because it is now apparently even more difficult to install the right binary on arm64... I doubt that the Debian package library will add a "chrome for testing" cross-platform package because it is much more niche than chromium (according to my understanding). |
* chore(deps): bump puppeteer from 19.11.1 to 20.0.0 Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.11.1 to 20.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v19.11.1...puppeteer-v20.0.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix: use `PUPPETEER_SKIP_DOWNLOAD` ref: puppeteer/puppeteer#10054 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Puppeteer switches to Chrome for Testing binaries by default. These binaries will be more similar to Chrome binaries than Chromium binaries in the future. Since the binary is different we mark the change as breaking and include a few other breaking changes related to how the browsers are installed:
BrowserFetcher
that can only deal with Chromium builds in favor of @puppeteer/browsers.mac-arm64
builds to be available for download (previously experimental).PUPPETEER_SKIP_CHROMIUM_DOWNLOAD
in favor ofPUPPETEER_SKIP_DOWNLOAD
since the flag always affected any browser, not only Chromium.PUPPETEER_CHROMIUM_REVISION
in favour ofPUPPETEER_BROWSER_REVISION
since the flag always affected any browser, not only Chromium./usr/bin/chromium-browser
on non-mac-arm64
platforms. Please define the executable path explicitly.DOWNLOAD_HOST
rewrites forchromium-browser-snapshots
.PUPPETEER_DOWNLOAD_HOST
now works as a base URL.