Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch to Chrome for Testing instead of Chromium #10054

Merged
merged 14 commits into from May 2, 2023

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 20, 2023

Puppeteer switches to Chrome for Testing binaries by default. These binaries will be more similar to Chrome binaries than Chromium binaries in the future. Since the binary is different we mark the change as breaking and include a few other breaking changes related to how the browsers are installed:

  • rolls Chrome for Testing 112.0.5615.121 (see https://goo.gle/chrome-for-testing).
  • removes BrowserFetcher that can only deal with Chromium builds in favor of @puppeteer/browsers.
  • enables mac-arm64 builds to be available for download (previously experimental).
  • removes ToT CI for now since we don't use it so much and we need to find a new way to test with an arbitrary version.
  • removes PUPPETEER_SKIP_CHROMIUM_DOWNLOAD in favor of PUPPETEER_SKIP_DOWNLOAD since the flag always affected any browser, not only Chromium.
  • removes PUPPETEER_CHROMIUM_REVISION in favour of PUPPETEER_BROWSER_REVISION since the flag always affected any browser, not only Chromium.
  • removes the fallback to /usr/bin/chromium-browser on non-mac-arm64 platforms. Please define the executable path explicitly.
  • removes the bisect script in favor of using browser-specific bisect tools.
  • removes compatibility DOWNLOAD_HOST rewrites for chromium-browser-snapshots. PUPPETEER_DOWNLOAD_HOST now works as a base URL.

@OrKoN OrKoN force-pushed the orkon/chrome-112.0.5615.121 branch 10 times, most recently from b3ad62c to 674ab69 Compare April 24, 2023 06:51
@OrKoN OrKoN changed the title feat: roll Chrome 112.0.5615.121 feat!: switch to using Chrome for Testing instead of Chromium Apr 24, 2023
@OrKoN OrKoN force-pushed the orkon/chrome-112.0.5615.121 branch 3 times, most recently from 9e454a2 to 0937d62 Compare April 24, 2023 07:47
@OrKoN OrKoN marked this pull request as ready for review April 24, 2023 07:47
@OrKoN OrKoN changed the title feat!: switch to using Chrome for Testing instead of Chromium feat!: switch to Chrome for Testing instead of Chromium Apr 24, 2023
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear summary in the PR description, and for making the changes in the first place! Nice work.

@OrKoN OrKoN force-pushed the orkon/chrome-112.0.5615.121 branch from 0937d62 to ead6b43 Compare April 24, 2023 08:08
@OrKoN OrKoN force-pushed the orkon/chrome-112.0.5615.121 branch 2 times, most recently from 2def08a to 3573863 Compare April 24, 2023 11:20
@OrKoN OrKoN force-pushed the orkon/chrome-112.0.5615.121 branch 4 times, most recently from 5016551 to e600197 Compare April 24, 2023 16:34
@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 24, 2023

Trying a different CfT version to see if PDF on Windows still has issues. Do not land please.

@OrKoN OrKoN force-pushed the orkon/chrome-112.0.5615.121 branch from 17e1cdb to eb7450c Compare April 28, 2023 08:15
@OrKoN OrKoN merged commit df4d60c into main May 2, 2023
32 checks passed
@OrKoN OrKoN deleted the orkon/chrome-112.0.5615.121 branch May 2, 2023 06:53
This was referenced May 2, 2023
@OrKoN
Copy link
Collaborator Author

OrKoN commented May 2, 2023

@kblok where do you see that? we renamed from Chromium to browser in many places, so exactly the opposite.

@kblok
Copy link
Contributor

kblok commented May 2, 2023

@OrKoN oh, sorry. My bad. Removing the comment to avoid confusion. Thank you!

TonyRL added a commit to DIYgod/RSSHub that referenced this pull request May 3, 2023
TonyRL pushed a commit to DIYgod/RSSHub that referenced this pull request May 3, 2023
* chore(deps): bump puppeteer from 19.11.1 to 20.0.0

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.11.1 to 20.0.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v19.11.1...puppeteer-v20.0.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: use `PUPPETEER_SKIP_DOWNLOAD`

ref: puppeteer/puppeteer#10054

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@drmrbrewer
Copy link

@OrKoN I'm currently installing the chromium package in my Debian environment to get the chromium binary needed for puppeteer. The reason I'm installing it myself, rather than relying on the binary bundled with puppeteer, is because puppeteer doesn't provide one for arm64.

It doesn't seem like there's a "chrome for testing" package for Debian, or even a "chrome" package. Can we continue to use the chromium binary? Or any thoughts on how I would go about installing the relevant "chrome for testing" binary on Debian?

@OrKoN
Copy link
Collaborator Author

OrKoN commented May 4, 2023

@drmrbrewer you can use Chromium, but we won't test with Chromium builds anymore. We are working on getting arm64 for Chrome for Testing but I cannot give an estimate.

@drmrbrewer
Copy link

@OrKoN OK thanks. That linked issue for arm64 has been open for 18 months now, and has collected over 70 thumbs-up votes, so it seems like there is a need... and this move to "chrome for testing" makes it even more pressing now, because it is now apparently even more difficult to install the right binary on arm64... I doubt that the Debian package library will add a "chrome for testing" cross-platform package because it is much more niche than chromium (according to my understanding).

nullqwertyuiop pushed a commit to nullqwertyuiop/RSSHub that referenced this pull request Jun 27, 2023
* chore(deps): bump puppeteer from 19.11.1 to 20.0.0

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.11.1 to 20.0.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v19.11.1...puppeteer-v20.0.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: use `PUPPETEER_SKIP_DOWNLOAD`

ref: puppeteer/puppeteer#10054

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gherceg added a commit to dimagi/commcare-hq that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants