fix: rename PUPPETEER_DOWNLOAD_HOST to PUPPETEER_DOWNLOAD_BASE_URL #10130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced May 4, 2023
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/base-url
branch
2 times, most recently
from
4bf1258
to
fa8a5c8
Compare
|
Can we deprecate then remove in a later release? |
|
Thinking a bit more, let’s hold off with this and I will add a deprecation warning for the download host |
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/base-url
branch
2 times, most recently
from
440452a
to
03503fd
Compare
Change to Chrome for Testing changed the servers we download binaries from so PUPPETEER_DOWNLOAD_HOST would not work as it used to because the rest of the file structure changed too. This change documents the breaking change and removes the PUPPETEER_DOWNLOAD_HOST in favour of PUPPETEER_DOWNLOAD_BASE_URL.
Lightning00Blade
approved these changes
May 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to Chrome for Testing changed the servers we download binaries from so PUPPETEER_DOWNLOAD_HOST would not work as it used to because the rest of the URL structure changed too. This change documents the change and deprecates the PUPPETEER_DOWNLOAD_HOST in favour of PUPPETEER_DOWNLOAD_BASE_URL.
Closes #10131