Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename PUPPETEER_DOWNLOAD_HOST to PUPPETEER_DOWNLOAD_BASE_URL #10130

Merged
merged 2 commits into from
May 5, 2023
Merged

fix: rename PUPPETEER_DOWNLOAD_HOST to PUPPETEER_DOWNLOAD_BASE_URL #10130

merged 2 commits into from
May 5, 2023

Commits on May 5, 2023

  1. feat!: rename PUPPETEER_DOWNLOAD_HOST to PUPPETEER_DOWNLOAD_BASE_URL 

    Change to Chrome for Testing changed the servers we download binaries
from so PUPPETEER_DOWNLOAD_HOST would not work as it used to because
the rest of the file structure changed too. This change documents
the breaking change and removes the PUPPETEER_DOWNLOAD_HOST in
favour of PUPPETEER_DOWNLOAD_BASE_URL.
    @OrKoN
    OrKoN committed May 5, 2023
    Configuration menu
    Copy the full SHA
    a1f43c1 View commit details
    Browse the repository at this point in the history

  2. chore: deprecate download host

    @OrKoN
    OrKoN committed May 5, 2023
    Configuration menu
    Copy the full SHA
    b3a113d View commit details
    Browse the repository at this point in the history