Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PUPPETEER_DOWNLOAD_PATH in favour of PUPPETEER_CACHE_DIR #10164

Closed
OrKoN opened this issue May 11, 2023 · 2 comments · Fixed by #11605
Closed

Deprecate PUPPETEER_DOWNLOAD_PATH in favour of PUPPETEER_CACHE_DIR #10164

OrKoN opened this issue May 11, 2023 · 2 comments · Fixed by #11605
Assignees
@OrKoN
Labels
confirmed feature

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented May 11, 2023

Both configuration options basically do the same thing. cc @jrandolf @Lightning00Blade
@OrKoN
Copy link
Collaborator Author

OrKoN commented May 11, 2023

See #10162

dr-js added a commit to dr-js/docker-stash that referenced this issue May 30, 2023
@dr-js
FIX: layer: node-pptr: use only PUPPETEER_CACHE_DIR env
6cc574a 
PUPPETEER_DOWNLOAD_PATH is ignored in some version & may be deprecated:
- puppeteer/puppeteer#10164
- puppeteer/puppeteer#10162
dr-js added a commit to dr-js/docker-stash that referenced this issue May 31, 2023
@dr-js
FIX: layer: node-pptr: use only PUPPETEER_CACHE_DIR env
aa23e26 
PUPPETEER_DOWNLOAD_PATH is ignored in some version & may be deprecated:
- puppeteer/puppeteer#10164
- puppeteer/puppeteer#10162
@stale
Copy link

stale bot commented Jul 10, 2023

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jul 10, 2023
@OrKoN OrKoN self-assigned this Jul 10, 2023
@OrKoN OrKoN mentioned this issue Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrKoN OrKoN

Labels
confirmed feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove PUPPETEER_DOWNLOAD_PATH in favor of PUPPETEER_CACHE_DIR puppeteer/puppeteer
1 participant
@OrKoN