Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Setting "PUPPETEER_SKIP_DOWNLOAD" env var to a falsy value skips browser installation #11080

Closed
2 tasks
xfournet opened this issue Oct 5, 2023 · 5 comments · Fixed by #11811
Closed
2 tasks
Assignees

Comments

@xfournet
Copy link

xfournet commented Oct 5, 2023

Minimal, reproducible example

export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=false
npm install

Error string

--> browser is not installed

Bug behavior

  • Flaky
  • PDF

Background

I want to disable browser download by default, and so i set

"puppeteer": {
    "skipDownload": true
  }

in my package.json

When i want to download the browser and would like to use the PUPPETEER_SKIP_DOWNLOAD env variable (which is preferred to the package.json configuration) and set it to false.

Expectation

Browser is installed

Reality

Browser is not installed

Puppeteer configuration file (if used)

No Puppeteer configuration file, package.json has

"puppeteer": {
    "skipDownload": true
  }

Puppeteer version

21.3.6

Node version

20.8.0

Package manager

npm

Package manager version

10.1.0

Operating system

Windows

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue has an outdated Puppeteer version: 21.3.6. Please verify your issue on the latest 21.6.0 version. Then update the form accordingly.


Analyzer run

@OrKoN
Copy link
Collaborator

OrKoN commented Oct 5, 2023

@jrandolf PTAL

Copy link

stale bot commented Dec 4, 2023

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@OrKoN
Copy link
Collaborator

OrKoN commented Dec 4, 2023

@jrandolf PTAL

@jrandolf
Copy link
Contributor

I cannot reproduce this issue.

@jrandolf jrandolf closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@jrandolf jrandolf reopened this Dec 12, 2023
jrandolf added a commit that referenced this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants