feat: download chrome-headless-shell by default and use it for the old headless mode #11754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
2 times, most recently
from
2d65e03
to
4d96cae
Compare
|
Hey folks, this is a reland for #11093 |
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
from
4d96cae
to
3bfd84f
Compare
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
2 times, most recently
from
0eeed62
to
29bbab9
Compare
Lightning00Blade
approved these changes
Jan 25, 2024
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
from
29bbab9
to
a040b63
Compare
Lightning00Blade
approved these changes
Jan 25, 2024
Merged
2 tasks
romaricpascal
added a commit
to alphagov/govuk-frontend
that referenced
this pull request
Jan 29, 2024
[Puppeteer now automatically downloads chrome-headless-shell](puppeteer/puppeteer#11754). It's used for old headless mode, which we don't use so we don't need to download it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, Puppeteer will download two binaries by default: a Chrome for Testing binary and a chrome-headless-shell of the same version.
chrome-headless-shellwill be used as a replacement for the old headless mode.Two new configurations are added:
PUPPETEER_SKIP_CHROME_DOWNLOADto skip Chrome binary downloads (only chrome-headless-shell will be downloaded).PUPPETEER_SKIP_CHROME_HEADLESS_SHELL_DOWNLOADto skip chrome-headless-shell binary downloads (only Chrome for Testing will be downloaded).Use these variables if you only want to use the old headless mode (chrome-headless-shell) or only the new-headless/headful mode (Chrome for Testing). The existing configuration
PUPPETEER_SKIP_DOWNLOADwould still apply to both binaries.