-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: download chrome-headless-shell by default and use it for the old headless mode #11093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
Oct 8, 2023
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
from
October 11, 2023 17:59
860eeaa
to
75760dd
Compare
@mathiasbynens I am not able to run M118 version on Mac:
|
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
4 times, most recently
from
October 31, 2023 10:49
ce8eb61
to
0f224ee
Compare
Looks like this now works after the upstream packaging changes (M120+)? LGTM |
mathiasbynens
approved these changes
Nov 6, 2023
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
3 times, most recently
from
December 6, 2023 14:36
22483a5
to
9b94c35
Compare
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
from
December 7, 2023 09:49
67c5bde
to
3254b45
Compare
OrKoN
force-pushed
the
orkon/chrome-headless-shell
branch
from
December 7, 2023 09:49
3254b45
to
17e16c6
Compare
mathiasbynens
approved these changes
Dec 7, 2023
OrKoN
changed the title
feat: download chrome-headless-shell by default
feat: download chrome-headless-shell by default and use it for the old headless mode
Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, Puppeteer will download two binaries by default: a Chrome for Testing binary and a chrome-headless-shell of the same version.
chrome-headless-shell
will be used as a replacement for the old headless mode.Two new configurations are added:
PUPPETEER_SKIP_CHROME_DOWNLOAD
to skip Chrome binary downloads (only chrome-headless-shell will be downloaded).PUPPETEER_SKIP_CHROME_HEADLESS_SHELL_DOWNLOAD
to skip chrome-headless-shell binary downloads (only Chrome for Testing will be downloaded).Use these variables if you only want to use the old headless mode (chrome-headless-shell) or only the new-headless/headful mode (Chrome for Testing). The existing configuration
PUPPETEER_SKIP_DOWNLOAD
would still apply to both binaries.BEGIN_COMMIT_OVERRIDE
chore: download chrome-headless-shell by default and use it for the old headless mode
END_COMMIT_OVERRIDE