Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download chrome-headless-shell by default and use it for the old headless mode #11093

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Oct 6, 2023

With this PR, Puppeteer will download two binaries by default: a Chrome for Testing binary and a chrome-headless-shell of the same version. chrome-headless-shell will be used as a replacement for the old headless mode.

Two new configurations are added:

  1. PUPPETEER_SKIP_CHROME_DOWNLOAD to skip Chrome binary downloads (only chrome-headless-shell will be downloaded).
  2. PUPPETEER_SKIP_CHROME_HEADLESS_SHELL_DOWNLOAD to skip chrome-headless-shell binary downloads (only Chrome for Testing will be downloaded).

Use these variables if you only want to use the old headless mode (chrome-headless-shell) or only the new-headless/headful mode (Chrome for Testing). The existing configuration PUPPETEER_SKIP_DOWNLOAD would still apply to both binaries.

BEGIN_COMMIT_OVERRIDE
chore: download chrome-headless-shell by default and use it for the old headless mode
END_COMMIT_OVERRIDE

@OrKoN OrKoN force-pushed the orkon/chrome-headless-shell branch from 860eeaa to 75760dd Compare October 11, 2023 17:59
@OrKoN
Copy link
Collaborator Author

OrKoN commented Oct 11, 2023

@mathiasbynens I am not able to run M118 version on Mac:

 ~/.cache/puppeteer/chrome-headless-shell/mac-118.0.5993.70/chrome-headless-shell-mac-x64/chrome-headless-shell -h
[1011/201316.703505:ERROR:icu_util.cc(178)] icudtl.dat not found in bundle
[1011/201316.703923:ERROR:icu_util.cc(240)] Invalid file descriptor to ICU data received.
[1]    27079 trace trap   -h

@OrKoN OrKoN force-pushed the orkon/chrome-headless-shell branch 4 times, most recently from ce8eb61 to 0f224ee Compare October 31, 2023 10:49
@mathiasbynens
Copy link
Member

Looks like this now works after the upstream packaging changes (M120+)? LGTM

@OrKoN OrKoN force-pushed the orkon/chrome-headless-shell branch 3 times, most recently from 22483a5 to 9b94c35 Compare December 6, 2023 14:36
@OrKoN OrKoN force-pushed the orkon/chrome-headless-shell branch from 67c5bde to 3254b45 Compare December 7, 2023 09:49
@OrKoN OrKoN force-pushed the orkon/chrome-headless-shell branch from 3254b45 to 17e16c6 Compare December 7, 2023 09:49
@OrKoN OrKoN marked this pull request as ready for review December 7, 2023 09:50
@OrKoN OrKoN changed the title feat: download chrome-headless-shell by default feat: download chrome-headless-shell by default and use it for the old headless mode Dec 7, 2023
@OrKoN OrKoN enabled auto-merge (squash) December 7, 2023 09:55
@OrKoN OrKoN disabled auto-merge December 7, 2023 09:56
@OrKoN OrKoN enabled auto-merge (squash) December 7, 2023 09:57
@OrKoN OrKoN merged commit 75ba27b into main Dec 7, 2023
54 checks passed
@OrKoN OrKoN deleted the orkon/chrome-headless-shell branch December 7, 2023 10:00
@release-please release-please bot mentioned this pull request Dec 7, 2023
jrandolf added a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants