Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 'userDataDir option should restore cookies' is flaky #1537

Closed
JoelEinbinder opened this issue Dec 4, 2017 · 1 comment · Fixed by #2327
Closed

Test 'userDataDir option should restore cookies' is flaky #1537

JoelEinbinder opened this issue Dec 4, 2017 · 1 comment · Fixed by #2327
Assignees
@JoelEinbinder
Labels
health

Comments

@JoelEinbinder
Copy link
Collaborator

Looks like there is still a race between closing chrome and writing cookies.
@JoelEinbinder JoelEinbinder self-assigned this Dec 4, 2017
@JoelEinbinder JoelEinbinder mentioned this issue Dec 4, 2017
Merged
aslushnikov pushed a commit that referenced this issue Dec 4, 2017
@JoelEinbinder @aslushnikov
test: disable 'userDataDir option should restore cookies' (#1538)
9fc39a4 
References #1537
@aslushnikov
Copy link
Contributor

There's an upstream bug for this: https://crbug.com/792187

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Apr 7, 2018
@aslushnikov
feat(Chromium): roll Chromium to r549031
416814c 
This roll includes:
- https://crrev.com/549003 - DevTools: make pptr tests pass with DCHECKs.

The patch fixes a browser crash that happens during browser close.
As a result, cookies were not saved properly (and thus the flaky test we
had).

Fixes puppeteer#1537.
@aslushnikov aslushnikov mentioned this issue Apr 7, 2018
Merged
aslushnikov added a commit that referenced this issue Apr 7, 2018
@aslushnikov
feat(Chromium): roll Chromium to r549031 (#2327)
45d97e5 
This roll includes:
- https://crrev.com/549003 - DevTools: make pptr tests pass with DCHECKs.

The patch fixes a browser crash that happens during browser close.
As a result, cookies were not saved properly (and thus the flaky test we
had).

Fixes #1537.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelEinbinder JoelEinbinder

Labels
health
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Chromium): roll Chromium to r549031 aslushnikov/puppeteer
2 participants
@aslushnikov @JoelEinbinder