Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: stop() should return Promise<Buffer> #2148

Closed
ebidel opened this issue Mar 6, 2018 · 4 comments
Closed

Tracing: stop() should return Promise<Buffer> #2148

ebidel opened this issue Mar 6, 2018 · 4 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Mar 6, 2018

It would be convenient if page.tracing.stop() returned Promise<Buffer> so users could act ton the trace JSON without saving a file to disk. This would also be consistent with the screenshot API.

@JoelEinbinder
Copy link
Collaborator

Pull requests welcome 😄

@ebidel
Copy link
Contributor Author

ebidel commented Apr 2, 2018

Ping.

@kblok
Copy link
Contributor

kblok commented Jul 19, 2018

@ebidel, @aslushnikov I know I'm quite late here 😜but, Why would it need to return a buffer instead of just a simple string? We are building a buffer based on a string. Why not just returning that string to the client?

@aslushnikov
Copy link
Contributor

aslushnikov commented Jul 19, 2018

@kblok iirc buffers are allowed to allocate more memory then strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants