Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript 2.8.0 fails to lint types #2279

Closed
aslushnikov opened this issue Mar 28, 2018 · 0 comments
Closed

TypeScript 2.8.0 fails to lint types #2279

aslushnikov opened this issue Mar 28, 2018 · 0 comments
Labels
health

Comments

@aslushnikov
Copy link
Contributor

TypeScript version 2.8.0 is failing to lint our codebase.

Example: https://cirrus-ci.com/task/4866025627582464

This requires some investigation; we'll use 2.7.0 for now.

cc @JoelEinbinder
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Mar 28, 2018
@aslushnikov
chore: fixate TypeScript to ~2.7.0
d03449f 
This patch fixates TypeScript release to 2.7.X.
For some reason, tsc 2.8.X fails to lint our types.

References puppeteer#2279
@aslushnikov aslushnikov mentioned this issue Mar 28, 2018
Merged
aslushnikov added a commit that referenced this issue Mar 28, 2018
@aslushnikov
chore: fixate TypeScript to ~2.7.0 (#2280)
71a07bb 
This patch fixates TypeScript release to 2.7.X.
For some reason, tsc 2.8.X fails to lint our types.

References #2279
This was referenced Mar 28, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov