Disable crash reporting by default #2778
Comments
Crashpad sometimes prevents us from removing a folder in tests. References puppeteer#2778.
Crashpad sometimes prevents us from removing a folder in tests. References #2778.
|
Does |
We were getting errors like `PermissionError: [WinError 5] Access is denied: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\resume.md_k098zhaj\\CrashpadMetrics-active.pma'` and `Exception ignored in: <finalize object at 0x16d9e039d60; dead> ... NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\resume.md_3aoun3f2\\CrashpadMetrics-active.pma'` in CI on Windows. See e.g. https://github.com/mikepqr/resume.md/runs/5172290981 and https://github.com/mikepqr/resume.md/runs/5172234014. The root cause was that Chrome creates a file the python process does not have permission to delete. See puppeteer/puppeteer#2778. Because TemporaryDirectory is intended to be used as a context manager there is no way to prevent it logging an error when cleanup fails. The fix is to switch to the lower level tempfile.mkdtemp, and make a good faith attempt to clean it up manually, logging failure at the debug level (while adding a new --debug option). A more sophisticated fix would be to backport the new ignore_cleanup_errors option added in python 3.10 (python/cpython#24793), but this will do. Fixes #13
We were getting errors like `PermissionError: [WinError 5] Access is denied: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\resume.md_k098zhaj\\CrashpadMetrics-active.pma'` and `Exception ignored in: <finalize object at 0x16d9e039d60; dead> ... NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\resume.md_3aoun3f2\\CrashpadMetrics-active.pma'` in CI on Windows. See e.g. https://github.com/mikepqr/resume.md/runs/5172290981 and https://github.com/mikepqr/resume.md/runs/5172234014. The root cause was that Chrome creates a file the python process does not have permission to delete. See puppeteer/puppeteer#2778. Because TemporaryDirectory is intended to be used as a context manager there is no way to prevent it logging an error when cleanup fails. The fix is to switch to the lower level tempfile.mkdtemp, and make a good faith attempt to clean it up manually, logging failure at the debug level (while adding a new --debug option). A more sophisticated fix would be to backport the new ignore_cleanup_errors option added in python 3.10 (python/cpython#24793), but this will do. Fixes #13
|
We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days. |
|
bump |
|
I can confirm that |
|
We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days. |
|
Tengo exactamente le mismo problema al iniciar multiples ventanas desde xdge , url |
|
Any progress on this? |
|
I am running with args |
|
have the same issue too that is a binary file that launched from /usr/lib, and also if remove that file, browser that won't start anymore, also flags cannot work too, also settings for disable that behavior won't found too. |
|
Same issue here, every time we close the browser and spawn a new one using puppeteer api it spawns a new chrome_crashpad_handler. Explains why our memory is creeping: |
We were getting errors like `PermissionError: [WinError 5] Access is denied: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\resume.md_k098zhaj\\CrashpadMetrics-active.pma'` and `Exception ignored in: <finalize object at 0x16d9e039d60; dead> ... NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\resume.md_3aoun3f2\\CrashpadMetrics-active.pma'` in CI on Windows. See e.g. https://github.com/mikepqr/resume.md/runs/5172290981 and https://github.com/mikepqr/resume.md/runs/5172234014. The root cause was that Chrome creates a file the python process does not have permission to delete. See puppeteer/puppeteer#2778. Because TemporaryDirectory is intended to be used as a context manager there is no way to prevent it logging an error when cleanup fails. The fix is to switch to the lower level tempfile.mkdtemp, and make a good faith attempt to clean it up manually, logging failure at the debug level (while adding a new --debug option). A more sophisticated fix would be to backport the new ignore_cleanup_errors option added in python 3.10 (python/cpython#24793), but this will do. Fixes #13
Win CI usually fails to cleanup userDataDir folder in some tests. Example: appveyour build
It turns out that on Windows:
As a result, we fail to remove temporary user data directory.
We need to disable crash reporting by default. Somehow chrome headless ignores the
--disable-breakpadflag and launches crashpad anyway; this requires investigation and fixing upstream.The text was updated successfully, but these errors were encountered: